Updating HLTtau Han config for HI in the context of [ATR-28130]
This MR comprises only a single file change under DataQualityConfigurations package: heavyions_run.config for the HLT/Tau which is the Han config file for this setup. The file is essentially copied from collisions_run.config under same folder. All tests mentioned in TWiki (han_lark returns 0, no seg. fault or crash, no histos under "overall status" and 4 CI tests) are conducted. The update is part of ATR-28130.
Merge request reports
Activity
added review-pending-level-1 label and removed Trigger label
CI Result SUCCESS (hash 80d68e41)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77275]- Resolved by Ogul Oncel
- Resolved by Ogul Oncel
- Resolved by Ogul Oncel
- Resolved by Ogul Oncel
- Resolved by Ogul Oncel
Hey @ooncel, The atlas bot is not a member in your fork. Please add the atlas bot as a Developer to your fork.
Apart from that I have a few minor comments regarding commented lines. Settings review-user-action-required
Cheers, Steffen (L1)
added review-user-action-required label and removed review-pending-level-1 label
added 1 commit
- f0356b24 - lines mentioned are already commented-out, as such, it makes sense to remove...
added 1 commit
- bd455bb1 - lines mentioned are already commented-out, as such, it makes sense to remove...
added 1 commit
- d59f8e86 - lines mentioned are already commented-out, as such, it makes sense to remove...
added 1 commit
- a4183f36 - lines mentioned are already commented-out, as such, it makes sense to remove...
added 1 commit
- 1125caad - lines mentioned are already commented-out, as such, it makes sense to remove...
Hi @skorn, thanks for reviewing the MR! I have applied all the suggestions you made since all are reasonably addressing removal of already-commented-out lines. I am thus removing the "review-user-action-required" tag. I have also added the ATLAS robot to my fork as a Developer.
Edited by Ogul Oncelremoved review-user-action-required label