Skip to content
Snippets Groups Projects

Updating HLTtau Han config for HI in the context of [ATR-28130]

Merged Ogul Oncel requested to merge ooncel/athena:dev_ogul into 23.0

This MR comprises only a single file change under DataQualityConfigurations package: heavyions_run.config for the HLT/Tau which is the Han config file for this setup. The file is essentially copied from collisions_run.config under same folder. All tests mentioned in TWiki (han_lark returns 0, no seg. fault or crash, no histos under "overall status" and 4 CI tests) are conducted. The update is part of ATR-28130.

Merge request reports

Pipeline #6164624 passed

Pipeline passed for 1125caad on ooncel:dev_ogul

Approval is optional

Merged by Jiri MasikJiri Masik 1 year ago (Sep 7, 2023 4:20pm UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Steffen Korn
  • Steffen Korn
  • Steffen Korn
  • Steffen Korn
  • Hey @ooncel, The atlas bot is not a member in your fork. Please add the atlas bot as a Developer to your fork.

    Apart from that I have a few minor comments regarding commented lines. Settings review-user-action-required

    Cheers, Steffen (L1)

  • Ogul Oncel added 1 commit

    added 1 commit

    • f0356b24 - lines mentioned are already commented-out, as such, it makes sense to remove...

    Compare with previous version

  • Ogul Oncel added 1 commit

    added 1 commit

    • bd455bb1 - lines mentioned are already commented-out, as such, it makes sense to remove...

    Compare with previous version

  • Ogul Oncel added 1 commit

    added 1 commit

    • d59f8e86 - lines mentioned are already commented-out, as such, it makes sense to remove...

    Compare with previous version

  • Ogul Oncel added 1 commit

    added 1 commit

    • a4183f36 - lines mentioned are already commented-out, as such, it makes sense to remove...

    Compare with previous version

  • Ogul Oncel resolved all threads

    resolved all threads

  • Ogul Oncel added 1 commit

    added 1 commit

    • 1125caad - lines mentioned are already commented-out, as such, it makes sense to remove...

    Compare with previous version

  • Hi @skorn, thanks for reviewing the MR! I have applied all the suggestions you made since all are reasonably addressing removal of already-commented-out lines. I am thus removing the "review-user-action-required" tag. I have also added the ATLAS robot to my fork as a Developer.

    cc: @smwang, @gipezzul

    Edited by Ogul Oncel
  • This merge request affects 1 package:

    • DataQuality/DataQualityConfigurations

    This merge request affects 1 file:

    • DataQuality/DataQualityConfigurations/config/HLT/HLTtau/heavyions_run.config

    Adding @ebergeas ,@ooncel as watchers

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading