fix to ZdcNtuple adding bunch group information, plus a fix to ZdcAnalysis

This merge request affects 2 packages:

ForwardDetectors/ZDC/ZdcAnalysis
ForwardDetectors/ZDC/ZdcNtuple

Affected files list will not be printed in this case

added 23.0 ForwardDetectors analysis-review-required review-pending-level-1 labels

CI Result SUCCESS (hash 4c958cdf)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77329]

added urgent label

bumping this to urgent, since it is! the fix is needed to avoid garbage ZDC amplitudes in the reconstruction output.

Hi

For the ZDCNtuple bit

I would imagine this is an algorithm that runs over a fixed input (like AOD) and not in any context (like during a reconstruction job) relying on the scheduler ?

At large it is nicer to use the AsgDataHandles. Most "Physics Algorithms" do. Random example https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/JetTruthTagAlg.h

But if you must urgently do this depends on how exactly is supposed to run.

If it runs on its own aka there are not algs either as "producers" of input (just read file ) or as consumers of output (just write Ntuples) then it would not matter in practice.

If it runs in any MT context and anything needs to be scheduled before or after then you need to move to handles.

But by the name would assume it does not run in such a context.

Hi Christos - thanks for having a look and I can't fully decide if there's anssue: until now it was just for reading xAOD files, but we are now running it as part of the Tier0 calibration loop sequence so the code expects the (non-MT) ZDC reconstruction to run first. I believe it's working at the moment because of the non-MT nature of the ZDC code, but perhaps it's too risky. But if I make even just one read handle for the ZDC containers, i.e. not each decoration, that should get the sequencer ordering right, correct?

Code changes look good and the discussion is not directly correlated with the changes, so not considered as a blocker.

Approving - L1

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added review-approved-tier0 label

removed review-approved-tier0 label

added review-user-action-required label

resolved all threads

@jmaurer - was the user-action-required tag waiting for the handles to be introduced?

resolved all threads

added 1 commit

9be00bbd - ZDC containers migrated to Read handles

Compare with previous version

This merge request affects 2 packages:

ForwardDetectors/ZDC/ZdcAnalysis
ForwardDetectors/ZDC/ZdcNtuple

Affected files list will not be printed in this case

added review-pending-level-1 label and removed review-approved review-approved-point1 review-user-action-required labels

CI Result SUCCESS (hash 9be00bbd)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77387]