Skip to content
Snippets Groups Projects

[ATR-28049] Support T0-style trigger reconstruction for Run 2 MC

Merged Tim Martin requested to merge tamartin/athena:resolveTrigR2CAReco into main

Very minimal changes actually needed, as the majority of "offline" trigger reconstruction for MC happens during the RDO to RDO_TRIG substep.

  • Continue to veto Run 1 MC (currently unsupported workflow)
  • Support R2 navigation thinning (similar to R3 MC)
  • Support R2->R3 navigation conversion. NOTE: We intent to initially do this via AOD->DAOD, but nice to be able to support it during AOD production too in the future for the next R2 reprocessing to AOD in 2025 (cc @wprzygod)
  • Support R3 AOD/ESD level navigation thinning on any R2->R3 conversion output.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @tamartin I only added a suggestion for fixing a typo; the rest looks fine from L1 point of view. Can you have a look?

    Setting review-user-action-required

    Cheers, Steffen (L1)

    Edited by Steffen Korn
  • Tim Martin resolved all threads

    resolved all threads

  • Tim Martin resolved all threads

    resolved all threads

  • Tim Martin added 1 commit

    added 1 commit

    • e44ae776 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigAnalysis/TrigNavSlimmingMT
    • Trigger/TrigEvent/TrigNavTools
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @martindl ,@fpastore ,@fwinkl as watchers

  • :x: CI Result FAILURE (hash e44ae776)

    Athena AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77504]

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TrigAnalysis/TrigNavSlimmingMT
    • Trigger/TrigEvent/TrigNavTools
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @martindl ,@fpastore ,@fwinkl as watchers

  • Frank Winklmeier resolved all threads

    resolved all threads

  • :x: CI Result FAILURE (hash e44ae776)

    Athena AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77520]

  • Author Developer

    OK, disregarding

    The following tests FAILED:
    	632 - SUSYTools_ut_SUSYToolsAlg_data_ctest (Failed)
    	633 - SUSYTools_ut_SUSYToolsAlg_data_Run3_ctest (Failed)
    	634 - SUSYTools_ut_SUSYToolsAlg_mc_ctest (Failed)
    	635 - SUSYTools_ut_SUSYToolsAlg_mc_Run3_ctest (Failed)

    as unrelated

  • MR looks fine. Failures in CI appear to be unrelated - Approving.

    Cheers, Steffen (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading