TrigDecisionTool: add AccumulatorCache to TDT Cfg functions

Add AccumulatorCache to TrigDecisionToolCfg and helper function. Not necessarily because of performance issues but to avoid multiple identical printouts in the job configuration.

Also delete deprecated getTrigDecisionTool.

added full-unit-tests label

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigDecisionTool

This merge request affects 1 file:

• Trigger/TrigAnalysis/TrigDecisionTool/python/TrigDecisionToolConfig.py

Adding @tamartin as watcher

added Trigger analysis-review-required main review-pending-level-1 labels

changed the description

removed Trigger analysis-review-required main review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash e43fed64)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77444]

added review-user-action-required label

added 1 commit

• 9c36b05b - RecJobTransforms: lock flags in legacy transforms

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• Reconstruction/RecJobTransforms
• Trigger/TrigAnalysis/TrigDecisionTool

Affected files list will not be printed in this case

Adding @goetz ,@tamartin as watchers

added Reconstruction Trigger analysis-review-required main review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash 9c36b05b)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77482]

added review-user-action-required label and removed review-pending-level-1 label

OK, now I remember why we didn't have the AccumulatorCache on the TDT. As long as we have to support legacy RecExCommon, we cannot easily lock the flags due to:

  13:32:15   File "/build2/ci-builds/main/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/RecJobTransforms/skeleton.RAWtoALL_tf.py", line 187, in <module>
  13:32:15     include( "RecExCommon/RecExCommon_topOptions.py" )
  13:32:15   File "/build2/ci-builds/main/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/RecExCommon/RecExCommon_topOptions.py", line 397, in <module>
  13:32:15     ConfigFlags = getNewConfigFlags()
  13:32:15   File "/build2/ci-builds/main/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/OldFlags2NewFlags.py", line 29, in getNewConfigFlags
  13:32:15     ConfigFlags.Input.Files = ( jobproperties.AthenaCommonFlags.FilesInput() or
  13:32:15   File "/build2/ci-builds/main/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 125, in __setattr__
  13:32:15     return self._flags._set( merged, value )
  13:32:15   File "/build2/ci-builds/main/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 333, in _set
  13:32:15     self._tryModify()
  13:32:15   File "/build2/ci-builds/main/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 364, in _tryModify
  13:32:15     raise RuntimeError("Attempt to modify locked flag container")
  13:32:15
  13:32:15 RuntimeError: Attempt to modify locked flag container

added 1 commit

• 0bf42ba4 - RecJobTransforms: lock flags in legacy transforms

Compare with previous version

removed full-unit-tests label

This merge request affects 2 packages:

• Reconstruction/RecJobTransforms
• Trigger/TrigAnalysis/TrigDecisionTool

Affected files list will not be printed in this case

Adding @goetz ,@tamartin as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 0bf42ba4)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77512]

added review-approved label and removed review-pending-level-1 label

Looks good to me. Approved.

Cheers L1

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit f1201b66

added sweep:ignore label