Trigger MET: Remove legacy code

We no longer need to support the legacy code that we had in place. This required a manual dependency mechanism for our inputs. Now we can do all of this with ComponentAccumulators.

Hopefully this should greatly simplify the code.

I did add a new StepOutput class to ensure that we a) keep the reco split by step and b) carry along aliased names of the various outputs we produce.

FAO @jwuerzin, @sidoti and @chenb

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@jburr ,@khamano ,@bcarlson ,@gemmeren ,@maszyman ,@ssnyder ,@lidiaz as watchers

added Core JetEtmiss Trigger TriggerMenu analysis-review-required full-unit-tests main review-pending-level-1 labels

CI Result FAILURE (hash 93158323)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77499]

added 1 commit

• ae349306 - 'Clusters' is a key not just a literal string

Compare with previous version

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@jburr ,@khamano ,@bcarlson ,@gemmeren ,@maszyman ,@ssnyder ,@lidiaz as watchers

CI Result FAILURE (hash ae349306)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77533]

changed title from Remove legacy code to Trigger MET: Remove legacy code

@jburr There seem to be a number of related failures in the CI. Can you have a look at them?

Setting review-user-action-required

Cheers, Steffen (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• fd809afb - Correctly use parOR

Compare with previous version

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@jburr ,@khamano ,@bcarlson ,@gemmeren ,@maszyman ,@ssnyder ,@lidiaz as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash fd809afb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77659]

The test failure seems to be known (https://its.cern.ch/jira/browse/ATR-28212)

OK from AR viewpoint, approved

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

jenkins please retry a build

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@jburr ,@khamano ,@bcarlson ,@gemmeren ,@maszyman ,@ssnyder ,@lidiaz as watchers

CI Result FAILURE (hash fd809afb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77775]