Skip to content
Snippets Groups Projects

Preventing HIModulator to schedule "NULL" as eventshapekey

Merged Sebastian Tapia Araya requested to merge stapiaar/athena:fix_himodulator into 23.0

Fix ATLASRECTS-7740

adding member "m_hasShapeKey" that checks if there is a valid key before initializing HIModulator

tagging @christos and HI conveners @angerami @qhu @mrybar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Sebastian Tapia Araya resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Reconstruction/HeavyIonRec/HIJetRec

    This merge request affects 2 files:

    • Reconstruction/HeavyIonRec/HIJetRec/Root/HIUEModulatorTool.cxx
    • Reconstruction/HeavyIonRec/HIJetRec/Root/HIUEModulatorTool.h

    Adding @goetz as watcher

  • :white_check_mark: CI Result SUCCESS (hash a21ddf05)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77724]

  • Changes look fine from L1 point of view - Approving.

    Cheers, Steffen (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Sebastian Tapia Araya resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Reconstruction/HeavyIonRec/HIJetRec

    This merge request affects 2 files:

    • Reconstruction/HeavyIonRec/HIJetRec/Root/HIUEModulatorTool.cxx
    • Reconstruction/HeavyIonRec/HIJetRec/Root/HIUEModulatorTool.h

    Adding @goetz as watcher

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading