Updates to RPD/Centroid Analysis and ZdcNtuple for Heavy Ions

Updates and Fixes:

• Add additional output to RPD analysis and integrate with ZdcAnalysisTool/ZdcNtuple
• Improve RPD baseline estimation by averaging over baseline samples
• Add option to cut on EM amplitude for centroid calculation
• Fix for RPD pileup evaluation which avoids potential TDecompLU errors (singular matrix when the number of points in normal equation is less than 2)
• Fix bug in RpdSubtractCentroidTool that applied wrong status bit in case of subtraction underflow

Minor changes:

• Rename variables and aux decorations for consistency and clarity
• Remove unused code in RPDDataAnalyzer
• Minor fixes and optimizations for RPDDataAnalyzer and ZdcNtuple
• Change sentinel value for RPD pileup fraction (RPDChannelPileupFrac) in case of zero or negative ADC sum to -1

added 34 commits

• c4d755cd...9184839c - 33 commits from branch atlas:23.0
• e8908976 - Merge branch '23.0' into '23.0-ntuple-rpd-update'

Compare with previous version

added 2 commits

• a231bdaf - add rpd maxadc to ZdcAnalysisTool and ZdcNtuple
• e2d6927d - Merge branch '23.0-ntuple-rpd-update' of...

Compare with previous version

changed the description

marked this merge request as ready

Jenkins please retry a build

@mhouseng you need to explicitly require a build when undrafting

This merge request affects 2 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple

Affected files list will not be printed in this case

added 23.0 ForwardDetectors analysis-review-required review-pending-level-1 labels

CI Result FAILURE (hash e2d6927d)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77890]

I suspect that the Athena test failure (divide by zero) is related to an unprotected division fixed in !65768 (merged).

resolved all threads

Switching tags while the discussions are ongoing.

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

marked this merge request as draft

added 1 commit

• 50b831c1 - add rpd raw data, baseline, and pileup info to ZdcNtuple

Compare with previous version

changed the description

changed title from Draft: Updates to ZdcNtuple and RPD baseline estimation to Draft: Updates to RPD analysis and ZdcNtuple

added 34 commits

• 50b831c1...5bbec1f5 - 26 commits from branch atlas:23.0
• ed92a589 - skip new global sum again
• 0ad121fb - Revert "skip new global sum again"
• b1c4786e - skip new global sum again
• 3dc15846 - Revert "skip new global sum again"
• b8fe2fc7 - improve RPD baseline estimation, add RPD max sample to ntuple
• a5a07ac0 - add rpd maxadc to ZdcAnalysisTool and ZdcNtuple
• 59c61dda - add rpd raw data, baseline, and pileup info to ZdcNtuple
• 148afba4 - Merge branch '23.0-ntuple-rpd-update' of...

Compare with previous version

added 1 commit

• 0b109ccd - simplify ntuple output for rpd raw

Compare with previous version

added 1 commit

• 52a47570 - remove unneeded write handles

Compare with previous version