Ppr/PPM/CPMMonitoring: Fix wrong variable type for event numbers and bug related to mismatch-event-counter
The event number variable used in the Ppr-,PPM, and CPM-Monitoring was inialized as integer, whereas it should be long long. This lead to negative event numbers (2-complement) or none at all.
The second bug that is fixed is related the mismatch event counter. The number of events with simulation mismatches which are dumped in the monitoring is limited to 10 events per lb. Due to a bug in the code the counter that tracks this was incremented for each event, not only for each event with an actual mismatch.
The first bug was fixed by changing the type, the second fix moves the counter incrementation to the correct scope.
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigT1/TrigT1CaloMonitoring
This merge request affects 3 files:
- Trigger/TrigT1/TrigT1CaloMonitoring/src/CpmSimMonitorAlgorithm.cxx
- Trigger/TrigT1/TrigT1CaloMonitoring/src/PPMSimBSMonitorAlgorithm.cxx
- Trigger/TrigT1/TrigT1CaloMonitoring/src/PprMonitorAlgorithm.cxx
added review-pending-level-1 label
CI Result SUCCESS (hash d9fc461c)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 77854]added review-approved label and removed review-pending-level-1 label
- Resolved by Julien Maurer
Changes look good to me. Approved.
Cheers L1
added review-approved-tier0 label
added review-approved-point1 label
mentioned in commit 4d0d9478
mentioned in merge request !65910 (merged)