Zdc led ntuple

This package adds ZDCLEDNtuple maker which takes reconstructed ZDC LED calibration data and writes it into dedicated Ntuple.

added 5 commits

• 7b72d129...5cddeaaa - 4 commits from branch atlas:23.0
• ccabf17c - Merge branch '23.0' into 'ZDC_LED_Ntuple'

Compare with previous version

added 1 commit

• fee78e03 - first analysed sample set to 5, deleted comments

Compare with previous version

marked this merge request as ready

Jenkins please retry a build

This merge request affects 1 package:

• ForwardDetectors/ZDC/ZdcNtuple

This merge request affects 5 files:

• ForwardDetectors/ZDC/ZdcNtuple/Root/LinkDef.h
• ForwardDetectors/ZDC/ZdcNtuple/Root/ZdcLEDNtuple.cxx
• ForwardDetectors/ZDC/ZdcNtuple/ZdcNtuple/ZdcLEDNtuple.h
• ForwardDetectors/ZDC/ZdcNtuple/ZdcNtuple/ZdcNtupleDict.h
• ForwardDetectors/ZDC/ZdcNtuple/src/components/ZdcNtuple_entries.cxx

added 23.0 ForwardDetectors review-pending-level-1 labels

CI Result SUCCESS (hash fee78e03)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78050]

Hi @lsudit, can you set the visibility of your fork to Internal and add the ATLAS robot as developer https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot such that the CI results are properly displayed. Thanks

A few comments added, and seconding the comment by @tstreble.

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

added 4 commits

• 217c71e6 - adding LEDType from ZDC sums
• beb725dc - tests for LedType
• b0db45b9 - led test
• afaa7375 - fix led types number to 0,1,2

Compare with previous version

This merge request affects 2 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple

Affected files list will not be printed in this case

added analysis-review-required review-pending-level-1 labels and removed review-user-action-required label

marked this merge request as draft

added 1 commit

• 1d4358ee - fix first analysed sample to 5, removed commented out code

Compare with previous version

resolved all threads

marked this merge request as ready

Jenkins please retry a build

This merge request affects 2 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple

Affected files list will not be printed in this case

CI Result SUCCESS (hash afaa7375)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78098]

CI Result SUCCESS (hash 1d4358ee)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78100]

resolved all threads

Is the L1 reviev considered done? If please flip the labels. Seeing ZDC I would think this may be urgent MR ... @lsudit is it so? Again, flag it with appropriate label.

added urgent label

We don't have any L1 shifter this morning unfortunately so directly jumping this to L2 @cvarni since it's urgent.

added review-pending-level-2 label and removed review-pending-level-1 label

There are some things I do not like personally, but it's more comments on code layout and very minor things. So I'm not delaying this any further. Approving

added review-approved label and removed review-pending-level-2 label

added 1 commit

• 20953b71 - changed fix array sizes to pre-difined variables

Compare with previous version

resolved all threads

resolved all threads

added 1 commit

• 5ea09d37 - changed fix loops ranges and modules, types to pre-difined

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple

Affected files list will not be printed in this case

added review-pending-level-1 label and removed review-approved label

This merge request affects 2 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple

Affected files list will not be printed in this case

Thanks @lsudit. I think we can consider this to be L1 reviewed. let me flip the labels.

removed review-pending-level-1 label

added review-approved-point1 label

mentioned in merge request !65752 (merged)

CI Result SUCCESS (hash 5ea09d37)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78118]