sweep of various EventLoop updates from main back into 21.2

The main thing we want here are the grid driver updates, but I figured it is easier/better to sweep everything that has been done so that I don't have to deal with merge conflicts. I left out one or two MRs that relied on code only present in main, and had to disable one newly introduced test for an experimental feature as it was having issues, and remove the new TEfficiency code for AthAnalysis.

Please note: Since this is a sweep aimed at making both branches consistent again, please restrict the review to things that really need to be fixed. Coding improvements ought to go into main and then be swept again.

List of commits swept:

• 83fed516
• 4896a147
• 3a644617
• 42df961f
• 596d22d3
• d5d96e7b
• 1e69ebd8
• ad662028
• 9741a87d
• 89eb51b2
• 744b2837
• afba793e
• 7ef3ba2b
• b8f1fafa
• b5b29495
• 402363af
• ca9b1e42
• f7ee0d7b
• 2e4007a5
• c8afa5ae
• c847bb6c
• 6ee8ac03
• bcafe535
• 56ad04a7
• 5c6dde2a
• 7b0bbaa3
• f391fec7

cc @aforti @mborodin @calpigia

This merge request affects 10 packages:

• Control/AthToolSupport/AsgTools
• Control/AthenaBaseComps
• PhysicsAnalysis/D3PDTools/AnaAlgorithm
• PhysicsAnalysis/D3PDTools/EventLoop
• PhysicsAnalysis/D3PDTools/EventLoopAlgs
• PhysicsAnalysis/D3PDTools/EventLoopGrid
• PhysicsAnalysis/D3PDTools/EventLoopTest
• PhysicsAnalysis/D3PDTools/MultiDraw
• PhysicsAnalysis/D3PDTools/RootCoreUtils
• PhysicsAnalysis/D3PDTools/SampleHandler

Affected files list will not be printed in this case

Adding @gemmeren ,@maszyman ,@krumnack ,@ssnyder as watchers

added 21.2 Analysis Core analysis-review-required review-pending-level-1 labels

This merge request affects 10 packages:

• Control/AthToolSupport/AsgTools
• Control/AthenaBaseComps
• PhysicsAnalysis/D3PDTools/AnaAlgorithm
• PhysicsAnalysis/D3PDTools/EventLoop
• PhysicsAnalysis/D3PDTools/EventLoopAlgs
• PhysicsAnalysis/D3PDTools/EventLoopGrid
• PhysicsAnalysis/D3PDTools/EventLoopTest
• PhysicsAnalysis/D3PDTools/MultiDraw
• PhysicsAnalysis/D3PDTools/RootCoreUtils
• PhysicsAnalysis/D3PDTools/SampleHandler

Affected files list will not be printed in this case

Adding @gemmeren ,@maszyman ,@krumnack ,@ssnyder as watchers

CI integration tests for projects AthDerivation are cancelled because of compilation error(s)

CI Result FAILURE (hash 62ca3e06)

	AthDerivation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AthDerivation: number of compilation errors 1, warnings 59
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 2304]

CI integration tests for projects AthAnalysis are cancelled because of compilation error(s)

Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

• Developers and shifters need to wait for both results, sometimes for additional hour or two.

CI Result FAILURE (hash 62ca3e06)

	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 240
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78218]

The compilation and test failures are not the usual ones for 21.2. Can these be looked into?

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

added 16 commits

• 62ca3e06...da699800 - 6 earlier commits
• 6e415934 - Update to batch driver to use CMAKE env variables
• ce73a420 - provide a default bevavior if GridWorker is run on unknown datasets
• d7ed9ef7 - allow enabling EventLoop grid error reporting outside of GridDriver/PrunDriver
• 2be01902 - resolve cppcheck defects; strange use of unique_ptr
• c68ce92d - remove GridDriver from release
• e8b1de42 - switch DuplicateChecker always to use unique submitDir
• ab7477c9 - fix to the fix of the DuplicateChecker
• 24564f36 - separate out input file handling into separate modules
• 830ad53a - ensure the leak-check test always uses a unique directory
• f76fe819 - emergency fix for the errors introduced by DirectInputModule

Compare with previous version

This merge request affects 9 packages:

• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/D3PDTools/AnaAlgorithm
• PhysicsAnalysis/D3PDTools/EventLoop
• PhysicsAnalysis/D3PDTools/EventLoopAlgs
• PhysicsAnalysis/D3PDTools/EventLoopGrid
• PhysicsAnalysis/D3PDTools/EventLoopTest
• PhysicsAnalysis/D3PDTools/MultiDraw
• PhysicsAnalysis/D3PDTools/RootCoreUtils
• PhysicsAnalysis/D3PDTools/SampleHandler

Affected files list will not be printed in this case

Adding @krumnack ,@ssnyder as watchers

added review-pending-level-1 label and removed review-user-action-required label

This merge request affects 9 packages:

• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/D3PDTools/AnaAlgorithm
• PhysicsAnalysis/D3PDTools/EventLoop
• PhysicsAnalysis/D3PDTools/EventLoopAlgs
• PhysicsAnalysis/D3PDTools/EventLoopGrid
• PhysicsAnalysis/D3PDTools/EventLoopTest
• PhysicsAnalysis/D3PDTools/MultiDraw
• PhysicsAnalysis/D3PDTools/RootCoreUtils
• PhysicsAnalysis/D3PDTools/SampleHandler

Affected files list will not be printed in this case

Adding @krumnack ,@ssnyder as watchers

Should be fixed. I hadn't realized this added something in the Athena-only path. Since there wasn't any obvious fix and this is mostly meant to keep the EventLoop code current, I chopped off that part of the commit. I updated the MR description to reflect that change.

changed the description

mentioned in merge request !61525 (merged)

mentioned in merge request !60987 (merged)

CI integration tests for projects AthDerivation are cancelled because of compilation error(s)

CI Result FAILURE (hash f76fe819)

	AthDerivation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AthDerivation: number of compilation errors 1, warnings 59
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 2305]

Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

• Developers and shifters need to wait for both results, sometimes for additional hour or two.

CI Result SUCCESS (hash f76fe819)

	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78240]

added 27 commits

• f76fe819...818e8eb7 - 17 earlier commits
• 4fe8fec5 - Update to batch driver to use CMAKE env variables
• fe7e6362 - provide a default bevavior if GridWorker is run on unknown datasets
• e1ef5b8a - allow enabling EventLoop grid error reporting outside of GridDriver/PrunDriver
• 3551b8a1 - resolve cppcheck defects; strange use of unique_ptr
• 283920d7 - remove GridDriver from release
• 3360b4d3 - switch DuplicateChecker always to use unique submitDir
• f0da53f3 - fix to the fix of the DuplicateChecker
• 7acfe1bd - separate out input file handling into separate modules
• 5ab4d1dc - ensure the leak-check test always uses a unique directory
• c133e5e5 - emergency fix for the errors introduced by DirectInputModule

Compare with previous version

This merge request affects 9 packages:

• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/D3PDTools/AnaAlgorithm
• PhysicsAnalysis/D3PDTools/EventLoop
• PhysicsAnalysis/D3PDTools/EventLoopAlgs
• PhysicsAnalysis/D3PDTools/EventLoopGrid
• PhysicsAnalysis/D3PDTools/EventLoopTest
• PhysicsAnalysis/D3PDTools/MultiDraw
• PhysicsAnalysis/D3PDTools/RootCoreUtils
• PhysicsAnalysis/D3PDTools/SampleHandler

Affected files list will not be printed in this case

Adding @krumnack ,@ssnyder as watchers

This merge request affects 9 packages:

• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/D3PDTools/AnaAlgorithm
• PhysicsAnalysis/D3PDTools/EventLoop
• PhysicsAnalysis/D3PDTools/EventLoopAlgs
• PhysicsAnalysis/D3PDTools/EventLoopGrid
• PhysicsAnalysis/D3PDTools/EventLoopTest
• PhysicsAnalysis/D3PDTools/MultiDraw
• PhysicsAnalysis/D3PDTools/RootCoreUtils
• PhysicsAnalysis/D3PDTools/SampleHandler

Affected files list will not be printed in this case

Adding @krumnack ,@ssnyder as watchers

I hope my latest push fixes the AthDerivation error. Unless there is a derivation docker image I'm really not set up to test derivations.

Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

• Developers and shifters need to wait for both results, sometimes for additional hour or two.

CI Result SUCCESS (hash c133e5e5)

	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78248]

CI Result SUCCESS (hash c133e5e5)

	AthDerivation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 2306]

There is a warning in the AnalysisBase build, but it is just a spurious warning that occasionally happens. I do not believe it is from this MR.

Sweep looks good, approving - L1

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

mentioned in commit ceefaac5

merged

added sweep:ignore label