Skip to content
Snippets Groups Projects

Herwig7_i: Add the new tune schemes

Merged Lukas Kretschmann requested to merge lkretsch/athena:Herwig7Dev_TunesNew into main

As part of this QT a new command for setting the tune schemes in Herwig7.2, as described in the H7.2 release note was introduced and already stuied, to investigate the impact of the diffrent tune schemes.

Local tests were performed to check the technical integration of the new command and first tune studies were carried out.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Code is looking good in principle, one comment on making it more modular and adhering to the longer docstring-style setters used elsewhere.

    • L1 shifter
  • added 1 commit

    Compare with previous version

  • Lukas Kretschmann resolved all threads

    resolved all threads

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 1 package:

    • Generators/Herwig7_i

    This merge request affects 1 file:

    • Generators/Herwig7_i/python/Herwig7Config.py
  • :pencil: :scissors: The system selected 1 tests to probe the Athena changeset (out of 73 available tests). Link to tests selection rules

  • :white_check_mark: CI Result SUCCESS (hash 3a8c788b)

    Athena AthGeneration
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78403]

  • Threads resolved. MR looks fine from L1 point of view - Approving.

    Cheers, Steffen (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit c1058468

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading