Skip to content
Snippets Groups Projects

DumpEventDataToJsonAlg: Clean up configuration and simplify algorithm

Merged DumpEventDataToJsonAlg: Clean up configuration and simplify algorithm
emoyse/athena:main-cleanup-dumper into main
All threads resolved!
Merged Edward Moyse requested to merge emoyse/athena:main-cleanup-dumper into main
All threads resolved!

Not much else to say - I simplified the algorithm to use DisableTool and removed some unneeded debug output

For the configuration, I made it work again on normal input by handling ACTS configuration dependencies better. Also, let's use fillFromArgs to reduce copy and pasting.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Steffen Korn
    Steffen Korn @skorn ·
    Developer

    @emoyse thanks for the MR. I only have one minor comment. Can you have a look?

    Cheers, Steffen (L1)

  • Steffen Korn added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Edward Moyse added 1 commit

    added 1 commit

    • 05bd234f - Remove commented code from DumpEventDataToJSONConfig.py

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Event/DumpEventDataToJSON

    This merge request affects 3 files:

    • Event/DumpEventDataToJSON/python/DumpEventDataToJSONConfig.py
    • Event/DumpEventDataToJSON/src/DumpEventDataToJsonAlg.cxx
    • Event/DumpEventDataToJSON/src/DumpEventDataToJsonAlg.h
  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system selected 32 tests to probe the Athena changeset (out of 73 available tests). Link to tests selection rules

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 05bd234f)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78443]

  • Steffen Korn resolved all threads

    resolved all threads

  • Steffen Korn
    Steffen Korn @skorn ·
    Developer

    Resolving threads. MR looks fine from L1 perspective - Approving.

    Cheers, Steffen (L1)

  • Steffen Korn added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Elmsheuser mentioned in commit 551723a7

    mentioned in commit 551723a7

  • Johannes Elmsheuser merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply