PileUpTools: Fix cppcheck warning.

We were getting a pointer from a unique_ptr that is then recorded in SG. Use std::launder to hide this fact from cppcheck so that it doesn't warn that the pointer lives past the end of the unique_ptr. But also fix the case where we may have actually used a dangling pointer if the record failed.

This merge request affects 1 package:

• Control/PileUpTools

This merge request affects 1 file:

• Control/PileUpTools/src/PileUpMergeSvc.cxx

Adding @ssnyder as watcher

added Core Digitization main review-pending-level-1 labels

The system selected 42 tests to probe the Athena changeset (out of 73 available tests). Link to tests selection rules

CI Result SUCCESS (hash 53011e1d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78428]

MR looks fine from L1 perspective - Approving.

Cheers, Steffen (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 84cb211d

added sweep:ignore label