Regional data for clustering

This MR is a first tentative idea on how to implement regional clusterization within our ACTS algorithms. This MR allows the clusterization to run on detector elements within an RoI. This MR however does not implement any mechanism to update the cluster collection, so multiple passes will not be allowed yet. That will be addressed in other MRs.

The idea of the code is the following:

• The clusterization algorithms always process an RoI, may that be the entire detector (FS) or specific area(s) of the detector
• At offline level, a FS RoI will be produced by an upstream algorithm (still to be written, will add soon) that will then be passed to the downstream algorithms. Alternatively, the user can provide their own RoIs collection.
• The clusterization algorithms retrieve the hash ids of the detector elements from the regions of the detector they have to process.
• A check is performed to verify the hash id is not already in the cluster collection in SG (this functionality is currently incomplete since we only create the cluster collection in the code, so it will always be empty)
• We run on the list of hash ids we have to process, retrieve the corresponding RDO collection and run clusterization on it

I still have to check if there is a potential overhead w.r.t. default code, or if there are smarter solutions

@sutt @keli @ncalace @pagessin @lgagnon @tbold @jmasik what is your opinion on this? Would this structure be ok?

By defining a dummy RoI, the code now performs clusterization only on specific regions of the detector:

added ACTS label

added 2 commits

• 8097629e - always process an RoI
• 732da0be - also for strips

Compare with previous version

I think in the long term we should think about unifying the logic between the Pixel and Strip cases, since at a glance they look very similar. That would ease the maintenance burden. To be clear I'm not suggesting to do it in this MR, just something to think about.

changed the description

added 1 commit

• fcad5e52 - make roi and view

Compare with previous version

added 1 commit

• 5becd885 - Dedicated tool for roi creation

Compare with previous version

added 1 commit

• 12f6f153 - Apply to ITk Reco JO

Compare with previous version

Giving this a try as is to see if I'm missing something obvious

Jenkins please retry a build

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsDataPreparation
• Tracking/Acts/ActsView

Affected files list will not be printed in this case

Adding @goetz ,@lgagnon ,@battagl ,@sroe ,@pagessin ,@jojungge ,@toyamaza ,@stsuno ,@tbold ,@lshan ,@cvarni as watchers

added ITk InnerDetector Tracking main labels

CI Result SUCCESS (hash 12f6f153)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78908]

added 1 commit

• cefcc7f3 - Adding JOs for testing configuration, full scan, single roi, composite roi

Compare with previous version

added 1 commit

• 210372f6 - renaming

Compare with previous version

added 1 commit

• dcbc888e - set the size for the accessors

Compare with previous version

resolved all threads

Jenkins please retry a build

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsDataPreparation
• Tracking/Acts/ActsView

Affected files list will not be printed in this case

Adding @goetz ,@lgagnon ,@battagl ,@sroe ,@pagessin ,@jojungge ,@toyamaza ,@stsuno ,@tbold ,@lshan ,@cvarni as watchers

The system selected 3 tests to probe the AthSimulation changeset (out of 11 available tests). Link to tests selection rules

CI Result SUCCESS (hash dcbc888e)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78942]

Hi @pagessin @jmasik I think this is ready for a first review from you. Can you take a look?

resolved all threads

marked this merge request as ready

added review-pending-level-1 label

un drafted!

added 619 commits

• dcbc888e...6e4d268d - 618 commits from branch atlas:main
• f930d2b0 - sync

Compare with previous version

Changing label to review-pending-expert while waiting for first review from @pagessin & @jmasik. Please change the label back if you'd like L1 to take a look too. Clara (L1)

added review-pending-expert label and removed review-pending-level-1 label

Hi @cnellist this MR has been discussed and approved during an ACTS-ITk meeting with the above mentioned people.

added review-pending-level-1 label and removed review-pending-expert label

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsDataPreparation
• Tracking/Acts/ActsView

Affected files list will not be printed in this case

Adding @goetz ,@lgagnon ,@battagl ,@sroe ,@pagessin ,@jojungge ,@tstreble ,@tbold ,@stsuno ,@toyamaza ,@lshan ,@cvarni as watchers

CI Result SUCCESS (hash f930d2b0)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79066]

I have a few trivial suggestions, but otherwise this is good to go. - L1 shifter.

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 7c672236 - comments

Compare with previous version

resolved all threads

thanks @adye I have implemented your suggestions

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsDataPreparation
• Tracking/Acts/ActsView

Affected files list will not be printed in this case

Adding @goetz ,@lgagnon ,@battagl ,@sroe ,@pagessin ,@jojungge ,@tstreble ,@tbold ,@stsuno ,@toyamaza ,@lshan ,@cvarni as watchers

added review-pending-level-1 label and removed review-user-action-required label

The system selected 3 tests to probe the AthSimulation changeset (out of 11 available tests). Link to tests selection rules

CI Result SUCCESS (hash 7c672236)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79106]

Changes look fine to me, the CI is good and all threads have been resolved. Sending on to L2 for a second look due to the size. Clara (L1)