Investigate an option of storing the event weight names in the MCEvent collection

Investigate an option of storing the event weight names in the MCEvent collection In practice the changes enable truth analyses from the MCEvent collection only.

What do you think @ewelina, @pclark, @jchapman?

Jenkins please retry the build

This merge request affects 1 package:

• Generators/GeneratorObjectsTPCnv

This merge request affects 2 files:

• Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/GenEvent_p7.h
• Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p7.cxx

Adding @gemmeren as watcher

added Generators main labels

The system selected 52 tests to probe the Athena changeset (out of 73 available tests). Link to tests selection rules

CI Result SUCCESS (hash 6cccefd6)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78765]

added 112 commits

• 6cccefd6...9f434687 - 111 commits from branch atlas:main
• 9fafc5ba - Merge remote-tracking branch 'upstream/main' into add_weight_names_to_McEventCollection

Compare with previous version

added 1 commit

• 3c8acff5 - OK

Compare with previous version

Jenkins please retry the build

This merge request affects 1 package:

• Generators/GeneratorObjectsTPCnv

This merge request affects 3 files:

• Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/GenEvent_p7.h
• Generators/GeneratorObjectsTPCnv/src/GeneratorObjectsTPCnv.cxx
• Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p7.cxx

Adding @gemmeren as watcher

The system selected 46 tests to probe the Athena changeset (out of 67 available tests). Link to tests selection rules

CI Result SUCCESS (hash 3c8acff5)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78871]

added 129 commits

• 3c8acff5...6b028ce1 - 128 commits from branch atlas:main
• d959620f - Merge remote-tracking branch 'upstream/main' into add_weight_names_to_McEventCollection

Compare with previous version

Jenkins please retry the build

This merge request affects 1 package:

• Generators/GeneratorObjectsTPCnv

This merge request affects 3 files:

• Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/GenEvent_p7.h
• Generators/GeneratorObjectsTPCnv/src/GeneratorObjectsTPCnv.cxx
• Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p7.cxx

Adding @gemmeren as watcher

The system selected 46 tests to probe the Athena changeset (out of 67 available tests). Link to tests selection rules

CI Result SUCCESS (hash d959620f)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79008]

added 42 commits

• d959620f...88aa6e25 - 41 commits from branch atlas:main
• 389fce8b - erge remote-tracking branch 'upstream/main' into add_weight_names_to_McEventCollection

Compare with previous version

added 1 commit

• 900c7124 - OK

Compare with previous version

added 1 commit

• 759e808e - OK

Compare with previous version

added 79 commits

• 759e808e...dc3d7d22 - 77 commits from branch atlas:main
• 41df48b3 - Merge remote-tracking branch 'upstream/main' into add_weight_names_to_McEventCollection
• a08a0f9c - OK

Compare with previous version

marked this merge request as ready

Jenkins please retry a build

This merge request affects 1 package:

• Generators/GeneratorObjectsTPCnv

This merge request affects 2 files:

• Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/GenEvent_p7.h
• Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p7.cxx

Adding @gemmeren as watcher

added review-pending-level-1 label

The system selected 43 tests to probe the Athena changeset (out of 64 available tests). Link to tests selection rules

CI Result SUCCESS (hash a08a0f9c)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79188]

removed review-pending-level-1 label

added review-user-action-required label

Changes look good from an L1 perspective.

The title makes me think that this is currently somewhat experimental? Is this ready to go in and can be approved or are you still waiting for some feedback @averbyts ?

Cheers

L1

Hi @jnitschk, the commit changes the persistent version 7, which is experimental. So the MR is ready to go, as I've tested it locally, but the code will be used only when v7 will be enabled.

Andrii

added review-pending-level-1 label

removed review-user-action-required label

Looks good then, approved.

Cheers L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit 838b59fe

merged

added sweep:ignore label