Implementing the option of differentiating between charge-conjugate parent...

Hi @tursom, should I add you as a reviewer?

Thank you @dmankad - the MR looks perfectly fine to me. Please go ahead.

marked this merge request as ready

added 1 commit

565e7b20 - Implementing the option of differentiating between charge-conjugate parent...

Compare with previous version

This merge request affects 1 package:

Generators/GeneratorFilters

This merge request affects 2 files:

Generators/GeneratorFilters/GeneratorFilters/ParentsTracksFilter.h
Generators/GeneratorFilters/src/ParentsTracksFilter.cxx

added 21.6 Generators review-pending-level-1 labels

CI Result SUCCESS (hash 565e7b20)

	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AthGeneration: number of compilation errors 0, warnings 4
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 2311]

Warnings are unrelated. Changes look fine to me. Sending to L2 for a second opinion on approving. Clara (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

I agree, changes are fine and warnings unrelated, approving...

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

Hi @ewelina, pinging just in case this has escaped notice. Thanks.

Hi @ewelina, can you merge this one?

Hi @dmankad I really am sorry for delay on this - somehow I overlooked this MR. Do you need a new release with this change? Cannot 23.6 be used? 21.6 is getting slowly deprecated ... Cheers, ewelinA

Hi Ewelina, thanks, no issues (nothing was really delayed due to the MR :)). We currently need this for a Run2 analysis that is being carried out with rel21 and the rest of the ntuples currently being used are in MC16.

mentioned in commit 505c9502

merged

added sweep:ignore label

Implementing the option of differentiating between charge-conjugate parent...

Merge request reports

Activity