Skip to content
Snippets Groups Projects

MuonG4R4 - Add muon sim hit sorting algorithm

Merged MuonG4R4 - Add muon sim hit sorting algorithm
jojungge/athena:AddSimHitSorting into main
All threads resolved!
Merged Johannes Junggeburth requested to merge jojungge/athena:AddSimHitSorting into main
All threads resolved!

Hi everybody,

this MR adds a small helper package to resort the xAOD::MuonSimHitContainer such that hits from the same chamber are close together in memory. The algorithm can either create a deep copy or a VIEW_ELEMENTS one which might not be super optimal in memory access patterns later. Anyway, if this should happen in the simulation job, the G4AtlasAlg needs to declare its dependencies. Introducing WriteHandleKeys to the senstive detectors is impossible as the master tool is held by service and by the G4AtlasAlg. Instead, the dependencies can be declared via the ExtraOutput property. I took the checkxAOD from a recent run 3 file to setup the containers for the other detectors as well. In case, of the Inner detector, I'm not really ceratin to what BCMHits & BLMHits belongs to

# checking [HITS/group.det-muon.33831012.EXT0._000060.HITS.pool.root]...
Py:AthFile           INFO loading cache from [athfile-cache.ascii.gz]...
Py:AthFile           INFO loading cache from [athfile-cache.ascii.gz]... [done]
Py:AthFile           INFO opening [HITS/group.det-muon.33831012.EXT0._000060.HITS.pool.root]...
================================================================================
                          Container type | StoreGate keys
-----------------------------------------+--------------------------------------
                         SiHitCollection | BCMHits, BLMHits, PixelHits, SCT_Hits
                           TileHitVector | MBTSHits, TileHitVec
            TRTUncompressedHitCollection | TRTUncompressedHits
                     TGCSimHitCollection | TGC_Hits
                     RPCSimHitCollection | RPC_Hits
                         LArHitContainer | LArHitEMB, LArHitEMEC, LArHitFCAL, LArHitHEC
                      xAOD::EventAuxInfo | EventInfoAux.
                      MMSimHitCollection | MM_Hits
                         xAOD::EventInfo | EventInfo
                     MDTSimHitCollection | MDT_Hits
                              DataHeader | StreamHITS
                   TrackRecordCollection | CaloEntryLayer, MuonEntryLayer, MuonExitLayer
                    sTGCSimHitCollection | sTGC_Hits
                       McEventCollection | TruthEvent
================================================================================
## Bye.

Tagging @jchapman, @tadej, @sroe as I'm curious to hear about their opinion

Edited by Johannes Junggeburth

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 7d030ab3 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 6 packages:

    • MuonSpectrometer/MuonG4/MuonG4SD
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
    • MuonSpectrometer/MuonPhaseII/MuonG4/MuonSensitiveDetectorsR4
    • MuonSpectrometer/MuonPhaseII/MuonG4/MuonSimHitSorting
    • Simulation/G4Atlas/G4AtlasAlg
    • Simulation/G4Atlas/G4AtlasTools

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 7d030ab3)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78959]

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 7af33d36 - Configure hits of the sillicon detectors as well

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 6 packages:

    • MuonSpectrometer/MuonG4/MuonG4SD
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
    • MuonSpectrometer/MuonPhaseII/MuonG4/MuonSensitiveDetectorsR4
    • MuonSpectrometer/MuonPhaseII/MuonG4/MuonSimHitSorting
    • Simulation/G4Atlas/G4AtlasAlg
    • Simulation/G4Atlas/G4AtlasTools

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 7af33d36)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :warning: :warning:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 1
    :warning: AthSimulation: number of compilation errors 0, warnings 1
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78972]

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Sending on to L2 to ease backlog. Clara (L1)

  • Clara Nellist added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Pavol Strizenec
  • Pavol Strizenec
  • Pavol Strizenec
    Pavol Strizenec @pavol ·
    Developer

    Please, @jojungge , fix the compilation warning, otherwise looks fine, I have two comments only...

    Pavol [as L2 MR shifter]

  • Pavol Strizenec added review-user-action-required label and removed review-pending-level-2 label

    added review-user-action-required label and removed review-pending-level-2 label

  • Johannes Junggeburth
  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 132d328e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 6 packages:

    • MuonSpectrometer/MuonG4/MuonG4SD
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
    • MuonSpectrometer/MuonPhaseII/MuonG4/MuonSensitiveDetectorsR4
    • MuonSpectrometer/MuonPhaseII/MuonG4/MuonSimHitSorting
    • Simulation/G4Atlas/G4AtlasAlg
    • Simulation/G4Atlas/G4AtlasTools

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@stavrop ,@kluit ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 132d328e)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79020]

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Threads have been resolved and the CI now looks good. Approving. Clara (L1)

  • Clara Nellist added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Edward Moyse mentioned in merge request !66215 (merged)

    mentioned in merge request !66215 (merged)

  • E
    Edward Moyse @emoyse ·
    Owner

    @jojungge does this really depend on !66215 (merged)? If not (and I can't really see how it can), can you remove the dependency so I can merge it?

  • Johannes Junggeburth
    Johannes Junggeburth @jojungge ·
    Author Developer

    aaah I scheduled the dependency because I should have touched the same lines of code then in !66215 (merged). In the version, there's no dependency. Let's get this in and follow-up with the remaining configuration modifications once that one is in

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit ed16ca8a

    mentioned in commit ed16ca8a

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply