ActsEvent: Increment surfaces with states and matching test
I had found that adding:
BOOST_CHECK_EQUAL(ts.hasReferenceSurface(), false);
to the unit tests caused an out of bounds exception.
I believe the problem was we need to increment m_surfaces
with the states (i.e. this: !66279 (diffs)
), but I would like @tbold and @wolter to confirm they agree?
(I had also to modify the fillTrackState
test function to handle the case where the surface WAS already filled).
cc @pagessin
Merge request reports
Activity
added ACTS Tracking main review-pending-level-1 labels
CI Result SUCCESS (hash e96dbe75)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78940]- Resolved by Edward Moyse
- Resolved by Tomasz Bold
@tbold should I wait to approve this one, or can we proceed? Clara (L1)
added review-approved label and removed review-pending-level-1 label
mentioned in commit 85795451
added sweep:ignore label
mentioned in merge request !65871 (closed)