Skip to content
Snippets Groups Projects

ActsEvent: Increment surfaces with states and matching test

Merged Edward Moyse requested to merge emoyse/athena:main-more-acts-edm into main
All threads resolved!

I had found that adding: BOOST_CHECK_EQUAL(ts.hasReferenceSurface(), false); to the unit tests caused an out of bounds exception.

I believe the problem was we need to increment m_surfaces with the states (i.e. this: !66279 (diffs) ), but I would like @tbold and @wolter to confirm they agree?

(I had also to modify the fillTrackState test function to handle the case where the surface WAS already filled).

cc @pagessin

Edited by Edward Moyse

Merge request reports

Pipeline #6294571 passed

Pipeline passed for e96dbe75 on emoyse:main-more-acts-edm

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 1 year ago (Oct 6, 2023 1:54pm UTC)

Merge details

  • Changes merged into main with 85795451 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good to me!

  • Edward Moyse resolved all threads

    resolved all threads

  • Tomasz Bold resolved all threads

    resolved all threads

  • Changes look fine and the CI is good. All threads resolved. Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 85795451

  • Edward Moyse mentioned in merge request !65871 (closed)

    mentioned in merge request !65871 (closed)

  • Please register or sign in to reply
    Loading