Skip to content
Snippets Groups Projects

Implement ACTS Surfaces in Muon ReadoutGeometry

Merged Dimitra Amperiadou requested to merge damperia/athena:myBranch into main

Implement functionallity to create the surfaces needed for navigation

Edited by Dimitra Amperiadou

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 1 year ago (Oct 17, 2023 11:40am UTC)

Merge details

  • Changes merged into main with 1721048a (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jenkins please retry a build

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4

    This merge request affects 11 files:

    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/MuonReadoutGeometryR4/MdtReadoutElement.h
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/MuonReadoutGeometryR4/MuonReadoutElement.h
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/MuonReadoutGeometryR4/MuonSurfaceCache.h
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/MuonReadoutGeometryR4/MuonTransformCache.h
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/MuonReadoutGeometryR4/RpcReadoutElement.h
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/MuonReadoutGeometryR4/sTgcReadoutElement.h
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/src/MdtReadoutElement.cxx
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/src/MuonReadoutElement.cxx
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/src/MuonSurfaceCache.cxx
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/src/RpcReadoutElement.cxx
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4/src/sTgcReadoutElement.cxx

    Adding @rosati ,@stavrop ,@kluit ,@jojungge ,@apsallid ,@pscholer as watchers

  • :white_check_mark: CI Result SUCCESS (hash 44e65517)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79036]

  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • added 1 commit

    • f4c8afc8 - Brief doc for muon surface cache

    Compare with previous version

  • Hi @damperia, can you update your fork to Internal and add the ATLAS bot as developer?

    https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot

    Thanks in advance

    Best, Thomas

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 1ccaeda1 - Inserting surface factories in Mdt Readout Element

    Compare with previous version

  • Jenkins please retry a build

  • Johannes Junggeburth
  • added 1 commit

    • 379069c8 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 60c26d7b - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading