Skip to content
Snippets Groups Projects

Turn off extra output

Merged Dan Guest requested to merge dguest/athena:quiet into main
All threads resolved!

This adds a few quality of life changes:

  • If the user sets the output level to WARNING or higher, disable the AppMgr spalsh screen
  • Pass output level to AppMgr
  • Don't produce a stack trace pointing back to the exception handler if it catches an exception

The last case was a bit weird so I moved it over to !66401 (merged).

Edited by Dan Guest

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Edward MoyseEdward Moyse 1 year ago (Oct 11, 2023 3:14pm UTC)

Merge details

  • Changes merged into main with 191ed989 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 1 package:

    • Control/AthenaConfiguration

    This merge request affects 1 file:

    • Control/AthenaConfiguration/python/MainServicesConfig.py

    Adding @gemmeren ,@ssnyder ,@maszyman as watchers

  • :x: CI Result FAILURE (hash 300b8365)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79163]

  • Dan Guest added 1 commit

    added 1 commit

    • 23686035 - remove controversial service

    Compare with previous version

  • Dan Guest mentioned in merge request !66401 (merged)

    mentioned in merge request !66401 (merged)

  • Dan Guest resolved all threads

    resolved all threads

  • Dan Guest changed title from Turn off extra output, disable stack trace to exception handler to Turn off extra output

    changed title from Turn off extra output, disable stack trace to exception handler to Turn off extra output

  • Dan Guest changed the description

    changed the description

  • This merge request affects 1 package:

    • Control/AthenaConfiguration

    This merge request affects 1 file:

    • Control/AthenaConfiguration/python/MainServicesConfig.py

    Adding @gemmeren ,@ssnyder ,@maszyman as watchers

  • :white_check_mark: CI Result SUCCESS (hash 23686035)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79225]

  • Looks good to me. Approved.

    Cheers L1

  • merged

  • Edward Moyse mentioned in commit 191ed989

    mentioned in commit 191ed989

  • Please register or sign in to reply
    Loading