DSPthr filling enhacement for HI
This brings a change to LAr DSP threshold computation, adjusted for HI event topology. Code is not used in any standard workflow, only in the conditions preparation jibs.
Merge request reports
Activity
This merge request affects 2 packages:
- LArCalorimeter/LArBadChannelTool
- LArCalorimeter/LArOnlDbPrep
Affected files list will not be printed in this case
Adding @pavol as watcher
added LAr main review-pending-level-1 labels
CI Result SUCCESS (hash ff101832)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79044]- Resolved by Pavol Strizenec
In general the changes look fine and the CI is good. Please consider removing the commented out code. Changing label to review-user-action-required until the thread is resolved. Clara (L1)
added review-user-action-required label and removed review-pending-level-1 label
This merge request affects 2 packages:
- LArCalorimeter/LArBadChannelTool
- LArCalorimeter/LArOnlDbPrep
Affected files list will not be printed in this case
Adding @pavol as watcher
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 2d9c02d3)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79165]added review-approved label and removed review-pending-level-1 label
mentioned in commit 12d8ae57
added sweep:ignore label