Skip to content
Snippets Groups Projects

DSPthr filling enhacement for HI

Merged Pavol Strizenec requested to merge pavol/athena:LArDB_fixes_4_main into main
All threads resolved!

This brings a change to LAr DSP threshold computation, adjusted for HI event topology. Code is not used in any standard workflow, only in the conditions preparation jibs.

Merge request reports

Pipeline #6318433 passed

Pipeline passed for 2d9c02d3 on pavol:LArDB_fixes_4_main

Merged by Edward MoyseEdward Moyse 1 year ago (Oct 11, 2023 3:08pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • In general the changes look fine and the CI is good. Please consider removing the commented out code. Changing label to review-user-action-required until the thread is resolved. Clara (L1)

  • Pavol Strizenec added 1 commit

    added 1 commit

    Compare with previous version

  • Pavol Strizenec resolved all threads

    resolved all threads

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 2 packages:

    • LArCalorimeter/LArBadChannelTool
    • LArCalorimeter/LArOnlDbPrep

    Affected files list will not be printed in this case

    Adding @pavol as watcher

  • :white_check_mark: CI Result SUCCESS (hash 2d9c02d3)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79165]

  • Changes look good to me. Approved.

    Cheers L1

  • merged

  • Edward Moyse mentioned in commit 12d8ae57

    mentioned in commit 12d8ae57

  • Please register or sign in to reply
    Loading