Skip to content
Snippets Groups Projects

Migrate FCS Param input file production workflow to CA

Merged Migrate FCS Param input file production workflow to CA
jchapman/athena:FCSParamInputSimCA_main into main
Merged John Derek Chapman requested to merge jchapman/athena:FCSParamInputSimCA_main into main

Add missing syntax to be able to properly configure production of inputs for FCS Param file generation using ComponentAccumulator. It is now possible to run FCS_Ntup_tf.py using ComponentAccumulator.

Currently this MR contains one bugfix to the legacy configuration and a change to the G4Optimizations enabled during the simulation step. Possibly these could be factored out?

Should fix ATLASSIM-6904.

Tagging @cyoung, @zhangr, @mbandier, @schaarsc, @mduehrss

Edited by John Derek Chapman

Merge request reports

Pipeline #6384137 passed

Stage: external

Pipeline passed for cbd9b17a on jchapman:FCSParamInputSimCA_main

Approval is optional

All merge request dependencies have been merged (1 merged)

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Oct 25, 2023 2:54pm UTC)

Merge details

  • Changes merged into main with c16c1668 (commits were squashed).
  • Deleted the source branch.

  • Closed ATLASSIM-6904

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • C
    Christopher Young @cyoung ·
    Developer

    Hi @jchapman In !66416 (merged) we will update the default files to point at the Run 3 config. Cheers, Chris.

  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Author Owner

    Thanks I've made this MR depend on !66416 (merged) as a reminder.

  • John Derek Chapman added 2 commits

    added 2 commits

    Compare with previous version

  • John Derek Chapman added 333 commits

    added 333 commits

    Compare with previous version

    Toggle commit list
  • John Derek Chapman changed the description

    changed the description

  • John Derek Chapman
  • John Derek Chapman added 1 commit

    added 1 commit

    Compare with previous version

  • John Derek Chapman resolved all threads

    resolved all threads

  • John Derek Chapman
  • John Derek Chapman resolved all threads

    resolved all threads

  • John Derek Chapman added 1 commit

    added 1 commit

    • edf1b898 - Use CA for HITtoRDO and RAWtoALL.

    Compare with previous version

  • John Derek Chapman
  • John Derek Chapman resolved all threads

    resolved all threads

  • John Derek Chapman added 1 commit

    added 1 commit

    • fff41eba - Allow legacy config for RAWtoESD for now.

    Compare with previous version

  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Author Owner

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 7 packages:

    • Simulation/BeamEffects
    • Simulation/ISF/ISF_Core/ISF_Services
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimSD
    • Simulation/ISF/ISF_Geant4/ISF_Geant4CommonTools
    • Simulation/ISF/ISF_HepMC/ISF_HepMC_Tools
    • Simulation/Tests/ISF_Validation

    Affected files list will not be printed in this case

    Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc ,@lmijovic as watchers

  • ATLAS Robot added Simulation main labels

    added Simulation main labels

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply