Draft: AthSimulation: cleanup package filters

Our cmake package configuration time scales badly with the number of patterns in the package_filters.txt. Use regular expressions to reduce the number of patterns from to 384 to 214, which reduces the cmake configuration time by ~90 seconds for this project.

Due to slightly more generic selection rules, the following additional packages are now built as part of AthSimulation:

Control/AthenaExamples/AthExThinning
Control/CoWTools
Control/PerformanceMonitoring/PerfMonTests
Control/StoreGateTests
Control/Valkyrie
Database/APR/APRTests
Database/CoolConvUtilities
Database/CoolRunQuery
Database/CoralUtilities
DetectorDescription/DetDescrCond/DetDescrCondExample
DetectorDescription/DetDescrCond/DetectorStatus
DetectorDescription/GeoModel/GeoModelExamples
Simulation/ISF/ISF_Geant4/ISF_Geant4Config

If needed, we could tune this further but these packages don't seem to hurt either.

cc @jchapman

added full-build full-unit-tests labels

Jenkins please retry a build

build area is cleaned as MR is labeled as full-build

This merge request affects 1 package:

• Projects/AthSimulation

This merge request affects 1 file:

• Projects/AthSimulation/package_filters.txt

Adding @jchapman ,@akraszna as watchers

added Build main labels

CI integration tests for projects AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash e4f1522c)

	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AthSimulation: number of compilation errors 22, warnings 64
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79179]

added 1 commit

• 00e81b62 - AthSimulation: cleanup package filters

Compare with previous version

Jenkins please retry a build

changed the description

marked this merge request as ready

changed the description

added 1 commit

• 89ea65cc - AthSimulation: cleanup package filters

Compare with previous version

build area is cleaned as MR is labeled as full-build

This merge request affects 1 package:

• Projects/AthSimulation

This merge request affects 1 file:

• Projects/AthSimulation/package_filters.txt

Adding @jchapman ,@akraszna as watchers

added review-pending-level-1 label

CI Result FAILURE (hash 89ea65cc)

	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79215]

removed review-pending-level-1 label

added review-user-action-required label

Thanks for the sytnax clean-up. A number of these packages were omitted from AthSimulation as the code is not used in full simulation production jobs and further they contain tests which have run-time dependencies on other packages which are not part of AthSimulation. We try to keep the size of these releases to a minimum and only include packages that are actually needed.

Indeed. I had to exclude a few more packages. Take a look a the updated package diff in the description. If you think some of these packages should really be excluded, we can do that of course. On the other side, having packages like StoreGateTests also run in AthSimulation seems probably a good idea (although I agree that it's extremely unlikely that it would show failures that haven't been seen in the full Athena build).

I think there is a case for including these packages for ease of debugging:

Control/PerformanceMonitoring/PerfMonTests
Control/StoreGateTests
Control/Valkyrie
Database/APR/APRTests

The rest are not needed for full simulation or debugging so should be vetoed:

Control/AthenaExamples/AthExThinning
Control/CoWTools
Database/CoolConvUtilities
Database/CoolRunQuery
Database/CoralUtilities
DetectorDescription/DetDescrCond/DetDescrCondExample
DetectorDescription/DetDescrCond/DetectorStatus
DetectorDescription/GeoModel/GeoModelExamples
Simulation/ISF/ISF_Geant4/ISF_Geant4Config

In fact Simulation/ISF/ISF_Geant4/ISF_Geant4Config isn't used anywhere and can be removed from the main branch even!