Add a CA version of loading SCTExtensionAlg.
This adds a SCTExtension.SCTExtensionAlgConfig.SCTExtensionAlgCfg
function that adds the SCTExtensionAlg
to ComponentAccumulator workflow. It is meant to replace the old share/SCTExtensionAlg.py
jobOptions. The ConfigFlags.Tracking.doTrackSegmentsPixel
also needs to be set to True
when running this algorithm.
The SCTExtensionAlg
is used for reconstruction of sampled for the MinBias analysis.
Merge request reports
Activity
This merge request affects 1 package:
- InnerDetector/InDetPerformance/SCTExtension
This merge request affects 3 files:
- InnerDetector/InDetPerformance/SCTExtension/CMakeLists.txt
- InnerDetector/InDetPerformance/SCTExtension/python/TransformUtils.py
- InnerDetector/InDetPerformance/SCTExtension/python/init.py
added InnerDetector main review-pending-level-1 labels
CI Result SUCCESS (hash 835e625b)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79219]added review-user-action-required label and removed review-pending-level-1 label
- Resolved by Jan-Eric Nitschke
Compilation warning says
share/SCTExtensionAlg.py:1:1: warning: ATL902: ATLAS Copyright statement missing
which is true, although not caused by this MR. (https://gitlab.cern.ch/atlas/athena/-/blob/0d1b6b3de1fab2f79db2bbc11de5c7ad600a362d/InnerDetector/InDetPerformance/SCTExtension/share/SCTExtensionAlg.py)
But i also saw the the copyright statement of the
__init__
file that was added in this MR is not up to date. So maybe you can fix both of those?Cheers L1
Edited by Jan-Eric Nitschke
added 2 commits
This merge request affects 1 package:
- InnerDetector/InDetPerformance/SCTExtension
This merge request affects 4 files:
- InnerDetector/InDetPerformance/SCTExtension/CMakeLists.txt
- InnerDetector/InDetPerformance/SCTExtension/python/TransformUtils.py
- InnerDetector/InDetPerformance/SCTExtension/python/init.py
- InnerDetector/InDetPerformance/SCTExtension/share/SCTExtensionAlg.py
added review-pending-level-1 label and removed review-user-action-required label
The system selected 1 tests to probe the Athena changeset (out of 64 available tests). Link to tests selection rules CI Result SUCCESS (hash 1195a618)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79256]added review-approved label and removed review-pending-level-1 label
- Resolved by Tadej Novak
- Resolved by Thomas Strebler
added review-user-action-required label and removed review-approved label
added 1 commit
- acebf9c3 - Rename TransformUtils.py to SCTExtensionAlgConfig.py.
This merge request affects 1 package:
- InnerDetector/InDetPerformance/SCTExtension
This merge request affects 3 files:
- InnerDetector/InDetPerformance/SCTExtension/CMakeLists.txt
- InnerDetector/InDetPerformance/SCTExtension/python/SCTExtensionAlgConfig.py
- InnerDetector/InDetPerformance/SCTExtension/share/SCTExtensionAlg.py
added review-pending-level-1 label and removed review-user-action-required label