Skip to content
Snippets Groups Projects

Add LLP DF flags + option to save full truth content; temporary fix to InDetTrackTruthFilterTool

Merged Jackson Carl Burzynski requested to merge jburzyns/athena:llp1-flags into main
All threads resolved!

This MR adds a new set of flags for Derivation.LLP, and an option in LLP1 to save the full truth particle and vertex containers with the preExec:

--preExec='flags.Derivation.LLP.saveFullTruth=True'

This also adds a flag to turn on/off running the extra track systematics, and sets it to False by default to avoid saving unnecessary information for background MC samples. The InDetTrackTruthFilterTool is also updated to fix an issue in LLP1 and IDTR2 do to a missing histogram (to be fixed once a new file is installed in the CalibArea)

Tagging @emmat, @calpigia, @tstreble

Edited by Jackson Carl Burzynski

Merge request reports

Pipeline #6324658 passed

Pipeline passed for a409fa9d on jburzyns:llp1-flags

Approval is optional

Merged by Edward MoyseEdward Moyse 1 year ago (Oct 13, 2023 1:10pm UTC)

Merge details

  • Changes merged into main with a549a3fc (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • This merge request affects 3 packages:

    • Control/AthenaConfiguration
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkLLP
    • PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools

    Affected files list will not be printed in this case

    Adding @jburzyns ,@emmat ,@dtrischu ,@calpigia ,@jcatmore ,@gemmeren ,@dshope ,@maszyman ,@ssnyder as watchers

  • added Analysis label

  • Jackson Carl Burzynski resolved all threads

    resolved all threads

  • Thomas Strebler resolved all threads

    resolved all threads

  • This targets derivations, so approving for analysis release purposes.

    Nils [Analysis RC]

  • :white_check_mark: CI Result SUCCESS (hash 9f5fbbd6)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79263]

  • :white_check_mark: CI Result SUCCESS (hash 01f15e42)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79262]

  • :white_check_mark: CI Result SUCCESS (hash a409fa9d)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79266]

  • The changes look okay and there are no issues with the CI. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Edward Moyse mentioned in commit a549a3fc

    mentioned in commit a549a3fc

  • Please register or sign in to reply
    Loading