FTAG: fix vertex labelling bug

This fixes a bug in the ftag truth vertex labelling spotted by @npond.

Reference: (before !62888 (merged) and !62544 (merged))

values: [-2 -1  0  1  2  3  4  5  6  7  8  9 10 11 12 13 14 15]
counts: [  473 13495  1676    84   105   117   107   113    99    77    52    33
    28    13     4     2     1     1]

Current:

values: [-2 -1  0  1  8]
counts: [  473 13495  2509     2     1]

This MR:

values: [-2 -1  0  1  2  3  4  5  6  7  8  9 10 11 12 13 14 15 16 17 18 19 20 21
 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 38 43]
counts: [  473 13495  1676    38    29    35    30    26    30    25    37    35
    27    33    38    41    38    38    29    19    46    37    30    29
    30    12    19    13     5     6    20     8     2     4     1     4
     8     1     3     8     2]

Note that the new labelling is per-event rather than per-jet so the vertex indices are higher in the current scheme. What is important is that the number of vertex indices == 0 (PV) is now equal (1676) and the number vertex indices >0 is also equal.

cc @jmwagner @jburzyns

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 3 files:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/TruthParticleDecoratorAlg.h
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthDecoratorHelpers.cxx
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthParticleDecoratorAlg.cxx

added Analysis BTagging JetEtmiss analysis-review-required main review-pending-level-1 labels

@dguest @bdong we should probably add our truth labels to the frozen derivation tests. Is that done by updating this file: https://acode-browser.usatlas.bnl.gov/lxr/source/athena/Tools/PROCTools/data/mc_PHYS_Run2_DAOD_PHYS_diff-interest-list.txt?

Do we add these to phys? Not sure it would work otherwise.

CI Result SUCCESS (hash a7a942b3)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79511]

resolved all threads

changed the description

Looks good to me, approving.

Cheers, Philipp (L1)

removed review-pending-level-1 label

added review-approved label

changed the description

Hi @svanstro,

I'm not sure if this affects analysis directly, if so, please add the Recommendation and/or bugfix labels. Otherwise approving from the analysis release side.

Cheers, Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit a4aeac98

added sweep:ignore label

mentioned in merge request atlas-flavor-tagging-tools/training-dataset-dumper!561 (merged)