Skip to content
Snippets Groups Projects

ZdcTrigSimFix

2 changes in this MR

  1. If we are in a trigger reprocessing, do not use the trigValidTool, it caused a crash from a circular dependency
  2. For normal reprocessing, have the trigValidTool use the new ZDC LUT w/ correct thresholds

tagging @asmaga @jkremer @steinber @bcole @rlongo

Merge request reports

Pipeline #6356094 passed

Pipeline passed for d91d150c on mhoppesc:23.0-ZdcTrigFixForRun3Data

Merged by Benjamin Philip KerridgeBenjamin Philip Kerridge 1 year ago (Oct 18, 2023 5:02pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthew Caleb Hoppesch resolved all threads

    resolved all threads

  • added 1 commit

    • d91d150c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 1 package:

    • ForwardDetectors/ZDC/ZdcRec

    This merge request affects 1 file:

    • ForwardDetectors/ZDC/ZdcRec/python/ZdcRecConfig.py
  • :white_check_mark: CI Result SUCCESS (hash d91d150c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79592]

  • Matthew Caleb Hoppesch resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading