Skip to content
Snippets Groups Projects

Changes to MTJ to enable introcution in tracking algs

Merged Tomasz Bold requested to merge tbold/athena:mtj-updates-for-deployement into main
All threads resolved!

This set of changes is followup of !66328 (closed) There the changes were too big and too many and needed to be split into a few. Another one is: !66462 (merged)

For now there is a few shortcuts made e.g. sourceLinks support basically any class but do not support persistency.

Tagging @cvarni @ncalace @pagessin @wolter @adye @ymanzas @emoyse ...

Merge request reports

Pipeline #6365162 passed

Pipeline passed for 0e5bedef on tbold:mtj-updates-for-deployement

Merged by Frank WinklmeierFrank Winklmeier 1 year ago (Oct 20, 2023 11:32am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni resolved all threads

    resolved all threads

  • Tomasz Bold added 337 commits

    added 337 commits

    Compare with previous version

  • This merge request affects 2 packages:

    • Event/xAOD/xAODTracking
    • Tracking/Acts/ActsEvent

    Affected files list will not be printed in this case

    Adding @akraszna ,@cvarni ,@tbold ,@toyamaza ,@jojungge ,@pagessin as watchers

  • :white_check_mark: CI Result SUCCESS (hash c0641609)

    Athena AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 62]

  • This looks like an offline tracking update, so approving for analysis release purposes.

    Nils [Analysis RC]

  • Looks good. Just one point to clarify before approving.

    Best, Thomas - L1

  • Tomasz Bold added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • Event/xAOD/xAODTracking
    • Tracking/Acts/ActsEvent

    Affected files list will not be printed in this case

    Adding @cvarni ,@tbold ,@jojungge ,@akraszna ,@pagessin ,@toyamaza as watchers

  • :white_check_mark: CI Result SUCCESS (hash 0e5bedef)

    Athena AthGeneration AnalysisBase AthAnalysis
    externals :cloud: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 109]

  • Thomas Strebler resolved all threads

    resolved all threads

  • Paul Gessinger resolved all threads

    resolved all threads

  • Looks good, approving - L1

  • added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier mentioned in commit 468ab5ec

    mentioned in commit 468ab5ec

  • Please register or sign in to reply
    Loading