Given that we have an enum mode make the HImodes just set this for now

Given that we have an enum mode, make the HImodes just set this for now This seems to cause some confusion in ftags if we still mix things (@jmaurer )

I assume that the enum now sets what was there so far in an "automatic" way. I do not know what is to be the future of this file.

Maybe the file should be kept in case in the future one wants to collect more "special" things. Maybe it should be eventually removed. Maybe something else ?

ping @stapiaar and @wlampl

This merge request affects 1 package:

• Reconstruction/HeavyIonRec/HIRecConfig

This merge request affects 1 file:

• Reconstruction/HeavyIonRec/HIRecConfig/python/HIModeFlags.py

Adding @goetz as watcher

added Reconstruction main review-pending-level-1 labels

marked this merge request as draft

changed target branch from main to 23.0

removed main label

added 23.0 label

marked this merge request as ready

CI Result SUCCESS (hash dcbe052c)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79564]

Hi @christos,

I think this is a good idea, to avoid confusion in the configuration of data and also MC like ATLHI-505.

I would not remove the file right now.

Cheers, Sebastian.

added 1 commit

• 3dd85942 - import the modeS

Compare with previous version

changed the description

This merge request affects 1 package:

• Reconstruction/HeavyIonRec/HIRecConfig

This merge request affects 1 file:

• Reconstruction/HeavyIonRec/HIRecConfig/python/HIModeFlags.py

Adding @goetz as watcher

changed the description

changed the description

CI Result SUCCESS (hash 3dd85942)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79569]

changed the description

added review-approved label and removed review-pending-level-1 label

Looks good to me. Approved.

Cheers L1

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit ab195152

merged

mentioned in merge request !66583 (merged)