Simulated forward electrons: improved matching between firmware and simulation

Previously the forward electron algorithm did not use pre-calculated lists of trigger tower IDs. This update use tower IDs in a similar way as jFEX jets. Note that the EM-fraction still use the outdated matching. Also fixes a mismatch of FPGA number at higher eta, this information is not propagated properly from the ELectronInfo object. The change is targeting 23.0 to make Tier-0 processing or P1 athena monitoring during last HI week.

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@will as watchers

added 23.0 L1Calo Trigger review-pending-level-1 labels

CI Result SUCCESS (hash 4f6369f3)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79595]

Hi @sjolin. For some reason it seems the CI pipeline status isn't displaying correctly in some places. Can you please check that you've added atlasbot as a developer to your fork as described here?

If the bot is already added, then can you check that your fork is not set to private? If it's private the CI status may not display correctly.

Thanks.

The changes look okay and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

removed review-approved-point1 label

added review-user-action-required label

removed review-approved label

added 1 commit

• 8a0fe415 - Replace goto statements with conditionals.

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@will as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash 8a0fe415)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79599]

Approving as Trigger RC, changes looked okay earlier (apart from use of goto which has been corrected)

added review-approved-point1 label

removed review-pending-level-1 label

mentioned in commit 97aa35d1