MainServicesCfg: Set up ValkyrieProfilerSvc if requested via flag

Simplify the usage of ValkyrieProfilerSvc: Add this service to the job if at least one algorithm is added to flags.PerfMon.ProfiledAlgs.

The ValkyrieProfilerSvc allows to run the profiler callgrind only on one (or some) algorithms.

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/MainServicesConfig.py

Adding @gemmeren ,@ssnyder ,@maszyman as watchers

added 23.0 Core analysis-review-required full-unit-tests review-pending-level-1 labels

Hey

I do not have an issue with the idea. Just making sure as when I added the valkyrie cfg I spent some (not much time) on this.

This "property" / flag enters in both

https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Control/Valkyrie/python/PerfMonValkyrieConfig.py#0013

https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Control/PerformanceMonitoring/PerfMonVTune/python/PerfMonVTuneConfig.py#0014

Of course if you do not run under "valgrind" or "vtune" there will be no much done

Also not sure if we use vtune in this mode . @amete will know.

I for sure use callgrind to get call trees and idea of what is going on for a single alg.

so would not be the best to know other cases

CI Result SUCCESS (hash a40dd5c7)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79598]

This looks like a pure Athena configuration update, approving for analysis release purposes.

Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-required label

Please resolved the open thread. Otherwise looks good.

Best, Thomas - L1

added review-user-action-required label and removed review-pending-level-1 label

mentioned in merge request !66719 (merged)

added 1 commit

• a9a74233 - Use new flag flags.PerfMon.Valgrind.ProfiledAlgs

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/MainServicesConfig.py

Adding @gemmeren ,@ssnyder ,@maszyman as watchers

added review-pending-level-1 label and removed review-user-action-required label

removed review-pending-level-1 label

added review-approved label

CI Result FAILURE (hash a9a74233)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79649]

removed review-approved label

added review-user-action-required label

Hmm

RAWtoALL 17:56:47   File "/build2/ci-builds/23.0/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/RecJobTransforms/RecoSteering.py", line 14, in RecoSteering
RAWtoALL 17:56:47     acc = MainServicesCfg(flags)
RAWtoALL 17:56:47   File "/build2/ci-builds/23.0/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/MainServicesConfig.py", line 293, in MainServicesCfg
RAWtoALL 17:56:47     if len(flags.PerfMon.Valgrind.ProfiledAlgs)>0:
RAWtoALL 17:56:47   File "/build2/ci-builds/23.0/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 113, in __getattr__
RAWtoALL 17:56:47     return getattr(self._flags, self._name + "." + name)
RAWtoALL 17:56:47   File "/build2/ci-builds/23.0/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 187, in __getattr__
RAWtoALL 17:56:47     raise AttributeError(f"No such flag: {name}")
RAWtoALL 17:56:47 AttributeError: No such flag: PerfMon.Valgrind

OK

[!66719 (merged)]

went to main (@amete), but this targets 23.0

I was sure it will succeed so got puzzled ...