GeneratorObjects: Avoid atomic operations on shared_ptr.

Atomic operations on shared_ptr turn out to be surprisingly expensive. Rework HepMcParticleLink to use CachedValue rather than holding an atomic shared_ptr. We can avoid having HepMcParticleLink increase in size by declaring the CachedValue as no_unique_address. Then m_evtColl can occupy the trailing padding of the CachedValue.

added full-integration-tests full-unit-tests labels

This merge request affects 1 package:

• Generators/GeneratorObjects

This merge request affects 9 files:

• Generators/GeneratorObjects/CMakeLists.txt
• Generators/GeneratorObjects/GeneratorObjects/CachedParticlePtr.h
• Generators/GeneratorObjects/GeneratorObjects/CachedParticlePtr.icc
• Generators/GeneratorObjects/GeneratorObjects/HepMcParticleLink.h
• Generators/GeneratorObjects/share/CachedParticlePtr_test.ref
• Generators/GeneratorObjects/share/HepMcParticleLink_test.ref
• Generators/GeneratorObjects/src/HepMcParticleLink.cxx
• Generators/GeneratorObjects/test/CachedParticlePtr_test.cxx
• Generators/GeneratorObjects/test/HepMcParticleLink_test.cxx

added Generators main review-pending-level-1 labels

cc Beojan @bstanisl

From my earlier timings: this takes a test MT digitization job from over 600 cpu.sec per event to about 170 cpu.sec per event.

CI Result SUCCESS (hash 0d001b44)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 73]

removed review-pending-level-1 label

added review-approved review-pending-level-1 labels

removed review-pending-level-1 label

Jobs needs a restart due to couple of technical problems (details posted on Mattermost)

Jenkins please retry a build

This merge request affects 1 package:

• Generators/GeneratorObjects

This merge request affects 9 files:

• Generators/GeneratorObjects/CMakeLists.txt
• Generators/GeneratorObjects/GeneratorObjects/CachedParticlePtr.h
• Generators/GeneratorObjects/GeneratorObjects/CachedParticlePtr.icc
• Generators/GeneratorObjects/GeneratorObjects/HepMcParticleLink.h
• Generators/GeneratorObjects/share/CachedParticlePtr_test.ref
• Generators/GeneratorObjects/share/HepMcParticleLink_test.ref
• Generators/GeneratorObjects/src/HepMcParticleLink.cxx
• Generators/GeneratorObjects/test/CachedParticlePtr_test.cxx
• Generators/GeneratorObjects/test/HepMcParticleLink_test.cxx

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS (hash 0d001b44)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 94]

Looks good, approving - L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 26dbbe43

added sweep:ignore label

mentioned in merge request !66554 (closed)