TgcReadoutGeometry clean up & removal of a couple of bugs (!66616) · Merge requests · atlas / athena · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption, please take a look at our documentation.

Johannes Junggeburth requested to merge jojungge/athena:TgcReadoutCleanUp into main Oct 20, 2023

Clean up interface of the TgcReadoutElement. Removal of unneeded functions. Uniform naming convention etc.
Optimize calculation of the wire group position. Remove recursive calculation approach in favour of a caching
Fix the calculation of the trapezoidal width for negative local Z

Prerequisite for ATLASSIM-7210

Validation of changes on simulation: TgcReadout_MC.pdf

Validation of changes on data: TgcReadout_Data.pdf

Tagging: @jdandoy, @christos, @jchapman, @jcatmore, @nstyles for the offline-sw-review-approved label

Tagging: @rbianchi, @turra to make them aware of upcoming changes in their physics validation campaign

Tagging: @kluit,@stavrop, @pscholer, @mvozak as experts

Edited May 31, 2024 by Johannes Junggeburth