Enabling DiTauSmearingAlg in CPAlgorithms

Following up from !66610 (merged) and as requested by @krumnack, this MR re-enabled the usage of DiTauSmearingAlg in CP Algorithms

Tagging @martindl

changed title from enablind DiTauSmearingTool in CPAlgorithms to Enabling DiTauSmearingAlg in CPAlgorithms

changed the description

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms

This merge request affects 3 files:

• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms/Root/DiTauSmearingAlg.cxx
• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms/TauAnalysisAlgorithms/DiTauSmearingAlg.h
• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms/src/components/TauAnalysisAlgorithms_entries.cxx

Adding @krumnack ,@tadej as watchers

added Analysis CPAlgorithms Tau analysis-review-required main review-pending-level-1 labels

CI Result SUCCESS (hash 330760ec)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 238]

Looks good to me, approving.

Cheers, Philipp (L1)

removed review-pending-level-1 label

added review-approved label

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit 4732f139

@ruyuan: This is a MR you should have set to analysis-review-expert instead of just approving.

@ademaria: This is only part of the work to enable di-tau for the CP algorithms. Please make sure you also check and enable the configuration here: https://gitlab.cern.ch/atlas/athena/-/tree/main/PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms/python

There are two configurations (for the time being), the old sequence configuration (in the *Sequence.py file), and the new block configuration (in the *Config.py file). There is already a sequence file that was migrated from 21.2 and you just need to verify that it is still current. The Config.py file does not yet exist (it exists for regular tau jets), but you can create it using the file for regular tau jets as a blueprint.

There are currently a large number of tests defined in the package, either enable them or remove them from the file (with any associated test configurations): https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms/CMakeLists.txt#L32-93

Then please also add it to our full sequence test/example sequence here: https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py#L306-336 https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py#L718-721

If you need help adding it to the test sequence I can assist with that. If you feel this is beyond you I can do that in a separate MR, but in that case you should absolutely set up a test (at least for the block configuration) in this MR.

It also needs to be added to the text configuration here: https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText.py#L385-390

At some point we may also want to consider whether or not to add this to PHYSLITE. However, that depends on whether you think this will have more than a handful of users, and if so we'd have to have a discussion in AMG or at the very least with the derivation experts.

Cheers, Nils [Analysis RC]

added sweep:ignore label