CPAlgorithms: change 'mc' to 'fullsim' in the config blocks metadata handling

This is technically a one-line change, but had to be propagated throughout the various CI tests and places that relied on the old string format.

In the future we might also want to change DataType.FastSim to distinguish between AF2 and AF3 (relevant for calibrations?), but I leave that to when we have a concrete use case.

This merge request affects 3 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting

Affected files list will not be printed in this case

Adding @krumnack ,@tadej ,@zmarshal as watchers

added Analysis CPAlgorithms analysis-review-required main review-pending-level-1 labels

There will be no AF2 in R24, and almost certainly only one fast simulation.

CI Result FAILURE (hash fac565a3)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 264]

added 1 commit

• a90ad88d - fix the definition of the unit tests

Compare with previous version

This merge request affects 3 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting

Affected files list will not be printed in this case

Adding @zmarshal ,@tadej ,@krumnack as watchers

CI Result FAILURE (hash a90ad88d)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 267]

added 1 commit

• 6c8b7522 - fix CI

Compare with previous version

This merge request affects 4 packages:

• AtlasTest/CITest
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting

Affected files list will not be printed in this case

Adding @pagessin ,@tadej ,@fwinkl ,@zmarshal ,@krumnack as watchers

added Test label

CI Result FAILURE (hash 6c8b7522)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 271]

I'm a little nervous about this change, not because it is bad per se, but because we had mc for so long. Is there a way we can also accept mc and translate that internally? We don't have to keep that around forever, but I'm just wondering whether we should have some backward compatibility for easier migration. With the block configuration we may be able to get away with it, but for the sequences I'm rather cautious.

added analysis-review-expert label and removed analysis-review-required label

Also the CI has some issues, so review-user-action-required .

Cheers, Philipp (L1)

removed review-pending-level-1 label

added review-user-action-required label

added 1 commit

• 353bf9bd - apply the changes suggested by Tadej

Compare with previous version

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/TriggerAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting

Affected files list will not be printed in this case

Adding @tadej ,@zmarshal ,@krumnack as watchers

added Tau Trigger review-pending-level-1 labels and removed review-user-action-required label

resolved all threads