ElectronCombinedMaterialEffects : Avoid repeated divisions

ElectronCombinedMaterialEffects : Avoid repeated divisions. div are typically more expensive that mult see [https://indico.cern.ch/event/252634/contributions/564148/attachments/440055/610507/2013-06-10-swtut.pdf] slide 3

this should prb change output at the following (0.00000183%) level

009.GSFTrackParticlesAuxDyn.trackParameterCovarianceMatrices.18.35 1.2134378835071402e-08 -> 1.2134377946892982e-08 => diff= [0.00000183%]

This merge request affects 1 package:

• Tracking/TrkFitter/TrkGaussianSumFilterUtils

This merge request affects 1 file:

• Tracking/TrkFitter/TrkGaussianSumFilterUtils/src/ElectronCombinedMaterialEffects.cxx

added Egamma Tracking main review-pending-level-1 labels

ping @jdandoy , @jchapman , @jcatmore . As will change the ouput at epsilon level and therefore will need some reference update. And can not approve my "own" things.

added RC Attention Required label

changed the description

added Run2-DataReco-output-changed Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 601c0057)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 285]

As expected The test came back

INFO       Py:diff-root         INFO Found [2] different leaves
INFO       Py:diff-root         INFO  [Trk::TrackCollection_tlp7_GSFTracks.m_hepSymMatrices.m_matrix_val]: 1 leaves differ
INFO       Py:diff-root         INFO  [xAOD::TrackParticleAuxContainer_v5_GSFTrackParticlesAuxDyn.trackParameterCovarianceMatrices]: 1 leaves differ

The "amount" of difference is in the description.

Anyhow I guess the shifter can look the changes but will need offline-sw-review-approved for the references to be updated

Also CC @nstyles

added review-user-action-required label

removed review-pending-level-1 label

resolved all threads

added offline-sw-review-approved label and removed review-user-action-required label

Looks fine to me - differences are tiny and come from a domain expert.

mentioned in merge request !66695 (merged)

added 1 commit

• 8fdb8851 - version update

Compare with previous version

This merge request affects 2 packages:

• Tools/WorkflowTestRunner
• Tracking/TrkFitter/TrkGaussianSumFilterUtils

Affected files list will not be printed in this case

added Tools review-pending-level-1 labels

resolved all threads

removed review-pending-level-1 label