TriggerMenuMT: forbid use of legacy properties in menu generation

Forbid the use of legacy properties in the L1/HLT menu generation. Several fixes were needed:

• Pass the flags in the L1 menu generation and remove usage of legacy flags. The menu name is still passed explicitly in some places, but in principle that could also just be taken from the flags. cc @khoo
• InDetRecExample: move globalflags import locally
• TrigInDetConfig: Remove usage of legacy job properties for Pixel/SCT ROB identifiers. Hard-code the values instead as they never change. cc @jmasik

added full-integration-tests full-unit-tests labels

changed the description

This merge request affects 2 packages:

• Trigger/TrigConfiguration/TrigConfigSvc
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cmorenom ,@lidiaz ,@jmharris ,@oliveirg ,@tamartin ,@asonay ,@paulama ,@orlando ,@sutt ,@mark as watchers

changed the description

added Trigger TriggerMenu main review-pending-level-1 labels

resolved all threads

added 4 commits

• d44b81c8 - TriggerMenuMT: use flags in L1 menu generation
• c42b36f8 - TrigInDetConfig: remove usage of legacy job properties
• a65f204c - InDetRecExample: move globalflags import locally
• d9ae85e5 - TriggerMenuMT: forbid usage of legacy job proprties in HLT menu generation

Compare with previous version

This merge request affects 4 packages:

• InnerDetector/InDetExample/InDetRecExample
• Trigger/TrigConfiguration/TrigConfigSvc
• Trigger/TrigTools/TrigInDetConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @nagano ,@sutt ,@goetz ,@orlando ,@jmharris ,@mvozak ,@cmorenom ,@tamartin ,@oliveirg ,@paulama ,@mark ,@sroe ,@lidiaz ,@asonay ,@keli as watchers

added InnerDetector TriggerID labels

changed title from TriggerMenuMT: use flags in L1 menu generation to TriggerMenuMT: forbid use of legacy properties in menu generation

changed the description

removed InnerDetector TriggerID labels

CI Result SUCCESS (hash d9ae85e5)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 294]

MR looks fine from L1 perspective - Approving.

Cheers, Steffen (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 69d3d25d

merged

added sweep:ignore label

mentioned in merge request !66769 (merged)

mentioned in commit 4e5123a9