main-cleanup2-PixelConditionsAlgorithms

Implement proposal 18 of ATLASRECTS-7721: Instead of using getFEI4HitDiscConfig with hardcoded arguments (0,0), which returns 2 in all cases, actually hardcode the value to 2 and thus save time.

This merge request affects 1 package:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms

This merge request affects 2 files:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelHitDiscCnfgAlg.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelHitDiscCnfgAlg.h

Adding @sroe ,@lshan ,@battagl ,@goetz ,@stsuno as watchers

added InnerDetector main review-pending-level-1 labels

CI Result FAILURE (hash 59b1c4f8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 292]

There are still a few CI issues, could you follow up on them?

Cheers, Philipp (L1)

added review-user-action-required label

removed review-pending-level-1 label

added 1 commit

• 93c4997e - remember to update the config

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms

This merge request affects 3 files:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms/python/PixelConditionsConfig.py
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelHitDiscCnfgAlg.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelHitDiscCnfgAlg.h

Adding @sroe ,@goetz ,@stsuno ,@lshan ,@battagl as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash 93c4997e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 300]

MR looks fine from L1 perspective - Approving.

Cheers, Steffen (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 7f72866f

added sweep:ignore label