Skip to content
Snippets Groups Projects

renamed: T_AthenaPoolTwoPersCnv.h -> T_AthenaPoolLegacyCnv.h

Merged Marcin Nowak requested to merge mnowak/athena:rename.to.LegacyCnv into main
All threads resolved!

Better name found.
This converter is not in use yet, no need to run tests.

Merge request reports

Pipeline #6389763 passed

Pipeline passed for 2887fa79 on mnowak:rename.to.LegacyCnv

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Oct 26, 2023 5:18am UTC)

Merge details

  • Changes merged into with 3563c2da.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @mnowak please resolve the thread.

    Cheers, Steffen (L1)

  • Marcin Nowak added 2 commits

    added 2 commits

    • 27814e71 - TwoPers converter used to write old Pers versions of some objects
    • 69de305b - rename Old / OldPers and PERSOLD to Legacy

    Compare with previous version

  • This merge request affects 2 packages:

    • Database/AthenaPOOL/AthenaPoolCnvSvc
    • InnerDetector/InDetEventCnv/InDetEventAthenaPool

    Affected files list will not be printed in this case

    Adding @sroe ,@maszyman ,@amete ,@goetz ,@mnowak ,@gemmeren ,@ssnyder as watchers

  • Marcin Nowak added 1 commit

    added 1 commit

    • 2887fa79 - Revert accidentally included changes to InDetSimDataCollectionCnv

    Compare with previous version

  • Marcin Nowak resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Database/AthenaPOOL/AthenaPoolCnvSvc

    This merge request affects 2 files:

    • Database/AthenaPOOL/AthenaPoolCnvSvc/AthenaPoolCnvSvc/T_AthenaPoolLegacyCnv.h
    • Database/AthenaPOOL/AthenaPoolCnvSvc/AthenaPoolCnvSvc/T_AthenaPoolTwoPersCnv.h

    Adding @mnowak ,@ssnyder ,@gemmeren ,@maszyman ,@amete as watchers

  • :pencil: :scissors: CI integration tests for projects Athena are cancelled because of compilation error(s)

  • :x: CI Result FAILURE (hash 69de305b)

    Athena AthSimulation AthGeneration AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 323]

  • :white_check_mark: CI Result SUCCESS (hash 2887fa79)

    Athena AthSimulation AthGeneration AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 326]

  • Looks good to me. Approved.

    Cheers L1

  • Vakhtang Tsulaia mentioned in commit 3563c2da

    mentioned in commit 3563c2da

  • Please register or sign in to reply
    Loading