main-cleanup-PixelToTPIDTool

Implement proposal 19 of ATLASRECTS-7721 : Hardcode getFEI4OverflowToT() to 16 as member of PixelChargeCalibCondData. Introduce retrieval of this instead of PixelModuleData in PixelToTPIDTool. Use new PixelChargeCalibCondData::getFEI4OverflowToT() in FEI4SimTool, FrontEndSimTool, RD53SimTool.

Jenkins please retry a build

This merge request affects 4 packages:

• InnerDetector/InDetCalibAlgs/PixelCalibAlgs
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConfig
• InnerDetector/InDetRecTools/PixelToTPIDTool

Affected files list will not be printed in this case

Adding @sroe ,@goetz ,@tstreble ,@battagl ,@stsuno ,@lshan as watchers

added InnerDetector main labels

CI Result SUCCESS (hash 15cc33b1)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 309]

added 1 commit

• 65d8db1d - add changes in digitization

Compare with previous version

Jenkins please retry a build

changed the description

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 5 packages:

• InnerDetector/InDetCalibAlgs/PixelCalibAlgs
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConfig
• InnerDetector/InDetDigitization/PixelDigitization
• InnerDetector/InDetRecTools/PixelToTPIDTool

Affected files list will not be printed in this case

Adding @sroe ,@tstreble ,@goetz ,@stsuno ,@lshan ,@jchapman ,@battagl as watchers

added Digitization label

CI Result SUCCESS (hash 65d8db1d)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 344]

added review-pending-level-1 label

added review-user-action-required label and removed review-pending-level-1 label

Changes look good to me. But this is still marked as draft. Is that intentional?

If this is ready and should be properly reviewed and approved please set it as ready.

Cheers L1

marked this merge request as ready

resolved all threads

removed review-user-action-required label

added review-pending-level-1 label

added review-approved label and removed review-pending-level-1 label

Looks good to me. Approved.

Cheers L1

mentioned in commit 9aebb62c

merged

added sweep:ignore label

mentioned in commit 1ad408b8

mentioned in merge request !66776 (closed)

mentioned in merge request !66773 (closed)