Skip to content
Snippets Groups Projects

LAr SC fixes for AP

Merged LAr SC fixes for AP
AtlasLArCalibration/athena:AP_fixes_SC into main
All threads resolved!
Merged Pavol Strizenec requested to merge AtlasLArCalibration/athena:AP_fixes_SC into main
All threads resolved!

These are fixes needed for LAr SC calibration data processing to run properly in AP. Code is not used in any standard workflows.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Oct 26, 2023 6:45pm UTC)

Merge details

  • Changes merged into main with 41789126 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • J
    Jan-Eric Nitschke @jnitschk ·

    Just some formatting/commenting comments. Otherwise this looks good to me.

    Cheers L1

  • Jan-Eric Nitschke added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Pavol Strizenec added 1 commit

    added 1 commit

    • ef71f287 - addressing MR shifter comments

    Compare with previous version

  • Pavol Strizenec resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • LArCalorimeter/LArCalibTools
    • LArCalorimeter/LArCalibUtils
    • LArCalorimeter/LArCnv/LArByteStream
    • LArCalorimeter/LArExample/LArCalibProcessing
    • LArCalorimeter/LArRecUtils

    Affected files list will not be printed in this case

    Adding @pavol as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ef71f287)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 381]

  • James Beacham
    James Beacham @jbeacham ·
    Developer

    The changes have been vetted already and there are no issues with the CI. Approving from L1.

  • James Beacham added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia mentioned in commit 41789126

    mentioned in commit 41789126

  • Vakhtang Tsulaia merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply