Skip to content
Snippets Groups Projects

ATLASRECTS-7788: Allow deserialisation to skip missing modules when handling multiple HLT results

Merged ATLASRECTS-7788: Allow deserialisation to skip missing modules when handling multiple HLT results
All threads resolved!
Merged Teng Jian Khoo requested to merge khoo/athena:main-TrigDeserialiser into main
All threads resolved!

When processing physics_Main, we attempt to deserialise all available HLT results, but this means we should not require e.g. the TLA HLT fragment to be present on every event. This is controlled by an option in TrigDeserialiser that is activated for the algs handling the data scouting fragments.

In the process of fixing this, also adjusting the ExtraInputs/Outputs to correctly schedule the GapFiller as suggested by @tamartin. Might help with ATR-28389.

Merge request reports

Pipeline #6392236 failed

Pipeline failed for aafcd584 on khoo:main-TrigDeserialiser

Approval is optional
Ready to merge by members who can write to the target branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I only have one small comment. Otherwise this looks good.

    Test failure seems to be unrelated: https://its.cern.ch/jira/browse/ATLASG-2623

    Cheers L1

  • Teng Jian Khoo added 1 commit

    added 1 commit

    • aafcd584 - Copy list arguments to prevent modification of defaults

    Compare with previous version

  • This merge request affects 2 packages:

    • Trigger/TrigSteer/TrigOutputHandling
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @fwinkl ,@tamartin ,@fpastore ,@martindl as watchers

  • :x: CI Result FAILURE (hash aafcd584)

    Athena AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :o: :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 363]

  • Jan-Eric Nitschke resolved all threads

    resolved all threads

  • Looks good to me now. (Test failures still unrelated https://its.cern.ch/jira/browse/ATLASG-2623)

    Cheers L1

  • Vakhtang Tsulaia mentioned in commit 71653991

    mentioned in commit 71653991

  • Please register or sign in to reply
    Loading