Introduce CaloDecoratorKernelCfg for EGAM + HIGG1 derivations

EGAM derivations are running MaxCellDecorator, GainDecoratorTool, ClusterEnergyPerLayerDecorator to decorate objects. In case several formats are run in parallel, this leads to the following error (see https://its.cern.ch/jira/browse/ATEAM-939)

https://bigpanda.cern.ch//media/filebrowser/d4f9c2a9-cfc2-4827-8785-fcb8f8e58cab/group.art/tarball_PandaJob_6002767659_GRIF-LPNHE/log.Derivation

05:03:39 EGAM2Kernel         ERROR SG::ExcStoreLocked: Attempted to modify auxiliary data in a locked store: `::E_Lr0_HiG' (2126)

To benefit from algorithm deduplication in the scheduler, a common CaloDecoratorKernelCfg is introduced and use in the different formats.

Also switch ConfigFlags to flags for consistency with other CA configs.

added Derivation Egamma NewConfig labels

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma

This merge request affects 11 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM1.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM10.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM11.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM12.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM2.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM3.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM4.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM5.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM7.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM8.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM9.py

Adding @emmat ,@calpigia ,@jcatmore as watchers

added main review-pending-level-1 labels

added 1 commit

• effbeace - Update ClusterEnergyPerLayerDecorator name

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma

This merge request affects 11 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM1.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM10.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM11.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM12.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM2.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM3.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM4.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM5.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM7.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM8.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM9.py

Adding @calpigia ,@emmat ,@jcatmore as watchers

changed title from Update GainDecoratorTool configs for EGAM derivations to Update public tool configs for EGAM derivations

changed the description

marked this merge request as draft

removed review-pending-level-1 label

CI Result SUCCESS (hash 91d82c92)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 549]

CI Result SUCCESS (hash effbeace)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 550]

added 2 commits

• f84cd3b4 - Switch ConfigFlags to flags in DerivationFrameworkCaloConfig
• ecc8ed95 - Add GainDecoratorKernelCfg

Compare with previous version

added 1 commit

• f3ee46b4 - Added CaloDecoratorKernelCfg

Compare with previous version

changed title from Draft: Update public tool configs for EGAM derivations to Draft: Introduce CaloDecoratorKernelCfg for EGAM + HIGG1 derivations

changed the description

added 2 commits

• 3c9f9219 - Add MaxCellDecoratorTool to CaloDecoratorKernelCfg
• 99d65028 - Update MaxCellDecorator config for LLP1

Compare with previous version

marked this merge request as ready

changed the description

Jenkins please retry a build

Derivations with multiple formats still failing afterwards with

DiphotonVertexK...  ERROR SG::ExcStoreLocked: Attempted to modify auxiliary data in a locked store: `::zvertex' (2615)

Probably related to PhotonPointingTool and interference between EGAM10 and HIGG1 format. Left for a subsequent MR.

This merge request affects 4 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkLLP

Affected files list will not be printed in this case

Adding @calpigia ,@emmat ,@jburzyns ,@dtrischu ,@dshope ,@jcatmore as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 99d65028)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 601]

Jenkins please retry a build

This merge request affects 4 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkLLP

Affected files list will not be printed in this case

Adding @calpigia ,@jburzyns ,@dshope ,@dtrischu ,@emmat ,@jcatmore as watchers

CI Result SUCCESS (hash 99d65028)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 629]

@tstreble

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo/python/DerivationFrameworkCaloConfig.py:55:5: warning: F841 local variable 'augmentationTools' is assigned to but never used
    augmentationTools = [

Can you please resolve this warning?

Cheers, Steffen (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• ec8c2ee2 - Fix MaxCellDecoratorKernelCfg

Compare with previous version

This merge request affects 4 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkLLP

Affected files list will not be printed in this case

Adding @dtrischu ,@emmat ,@dshope ,@jburzyns ,@jcatmore ,@calpigia as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash ec8c2ee2)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 635]

MR looks fine from L1 perspective, CI shows no problems - approving.

Cheers, Steffen (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d7eb73d5