Skip to content
Snippets Groups Projects

Make FCS ART test in G4 MT rather than ST

Merged Make FCS ART test in G4 MT rather than ST
cyoung/athena:main-FCS-ART into main
All threads resolved!
Merged Christopher Young requested to merge cyoung/athena:main-FCS-ART into main
All threads resolved!

This merge request changes the ART test for running FastCaloSim in AtlasG4_tf.py from a single thread test to a multithread test. The motivation for this is a) this is how we usually run simulation b) the memory requirements for this are high so it sometimes causes failures ATLASSIM-6931

Tagging @mbandier @schaarsc @zhangr @jchapman @jbeirer

Merge request reports

Pipeline #6420023 passed

Stage: external

    Pipeline passed for 5fa0c15f on cyoung:main-FCS-ART

    Approval is optional

    Merged by Johannes ElmsheuserJohannes Elmsheuser 1 year ago (Nov 1, 2023 5:05pm UTC)

    Merge details

    • Changes merged into main with ee09b6bd (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Christopher Young resolved all threads

    resolved all threads

  • Christopher Young added 1 commit

    added 1 commit

    • 5fa0c15f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Simulation/Tests/SimCoreTests
    • Simulation/Tests/SimCoreTestsMT

    Affected files list will not be printed in this case

    Adding @jchapman as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 5fa0c15f)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 633]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 08e1b65e)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 632]

  • Steffen Korn
    Steffen Korn @skorn ·
    Developer

    MR looks fine from L1 perspective - Approving.

    Cheers, Steffen (L1)

  • Steffen Korn added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Elmsheuser merged

    merged

  • Johannes Elmsheuser mentioned in commit ee09b6bd

    mentioned in commit ee09b6bd

  • Joshua Falco Beirer mentioned in merge request !67102 (merged)

    mentioned in merge request !67102 (merged)

  • Joshua Falco Beirer mentioned in commit 97fa7e97

    mentioned in commit 97fa7e97

  • Julien Maurer mentioned in commit ed992674

    mentioned in commit ed992674

  • Walter Lampl mentioned in merge request !67122 (merged)

    mentioned in merge request !67122 (merged)

  • Walter Lampl mentioned in commit 062ae320

    mentioned in commit 062ae320

    • Please register or sign in to reply