Speedup and cleanup of LArDigitalTriggMonAlg

As reported in ATLASRECTS-7798, the monitoring algorithm LArDigitalTriggMonAlg is horribly slow. This MR brings the execution speed down to about 100ms/event, mostly because the call to fill was pulled out of a tight loop over all supercells

On top of the speedup, the code was streamlined and lots of dead/unnecessary code was removed.

I expect the histogram output to change because the current version had at least two obvious bugs:

• The event-size counter started with -1 instead of 0
• The LArOnlineID helper class (for regular readout) was used instead of the LArOnline_SuperCellID helper

There are a few more suspicous details we should address, therefore this MR remains a draft for now.

cc @ekay

assigned to @wlampl

added 6 commits

• 8b8da51b - fix flake8 warning
• b1df1286 - merge (squash) commit from Ellis
• 08b741dc - property-check, use boolean for ADC_BAS, re-arrange header-file for readability
• 93a57606 - adjust job-config
• 6b4512a7 - fix property check
• b2d0d542 - remove unused variable and commented-out code-lines

Compare with previous version

resolved all threads

added 1 commit

• 773ae332 - improve handling of intermediate vectors

Compare with previous version

marked this merge request as ready

Un-draft'ing as this is IMHO now good to go in.

Jenkins please retry a build

This merge request affects 1 package:

• LArCalorimeter/LArMonitoring

This merge request affects 3 files:

• LArCalorimeter/LArMonitoring/python/LArDigitalTriggMonAlg.py
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.cxx
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.h

Adding @pavol as watcher

added DQ LAr Trigger main review-pending-level-1 labels

approved this merge request

CI Result FAILURE (hash 773ae332)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 884]

added 1 commit

• 513f9e21 - Adjust job config, part 2

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArMonitoring

This merge request affects 3 files:

• LArCalorimeter/LArMonitoring/python/LArDigitalTriggMonAlg.py
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.cxx
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.h

Adding @pavol as watcher

CI Result SUCCESS (hash 513f9e21)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 892]

removed review-pending-level-1 label

added review-approved label