Skip to content

LarIdentifier : Do not "cache" all previous messages

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:fix_growing_strings_LarIdentifier into main

In the context of ATLINFR-5144

@fwinkl noticed that the error messages go

11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 1
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 12
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 123
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 1234
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 12345
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 123456
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0][4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 1234567
....

aka we increase constantly the string to print, this prb leads to also increased memory consumption and larger logs. The real issue is why we get the ERRORs obviously .

But prb we want

11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 1
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 2
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 3
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 4
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 5
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 6
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  expanded Id= [4.4.0.0.0.1.0.0]
11-09 14:30 INFO       LArOnlineID_Base                             0    0      ERROR  init_hashes: duplicated id for feedthrough nb = 7
....

In theory this might had left the (or some of the) jobs finish and I assume we could have seen the ERROR in the log scan or so.

This is more of a symptom but could help to fix it.

ping @fwinkl , @ssnyder , @elmsheus @aundrus

Merge request reports