gFEX Jet Algo Updates

With this MR, major updates of the gFEX simulation, and in particular the jet finder algorithm, are included to reproduce what is in the gFEX firmware. The required changes are documented in ATLGFEX-124 and in this presentation, where a better agreement between TOBs from data and emulated ones is shown after the updates.

More specifically, the main changes are the following:

• Combine the two halves of the FPGA-C gTower input (forward-negative and forward-positive) into one matrix with the correct format (12x32 towers) as done in the firmware, and as required by the jet algorithm;
• Update the calculation of the large-R jets when including partial sums from towers of adjacent FPGAs;
• Update pile-up calculation, including a look-up table as in the firmware, and use gTowers with 50 MeV resolution (saved in the input ByteStream decoder) as input to the calculation (as opposed to the default 200 MeV towers).

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@will as watchers

added JetEtmiss L1Calo Trigger main review-pending-level-1 labels

CI Result FAILURE (hash 58120f6e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 912]

Jenkins please retry a build

Restarting job after resolution of problems detailed in https://its.cern.ch/jira/browse/ATLINFR-5144

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @will ,@thompson as watchers

CI Result FAILURE (hash 58120f6e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 931]

added review-user-action-required label

removed review-pending-level-1 label

@ctosciri there are a few warnings and errors in the CI. Can you please have a look?

Cheers, Steffen (L1)

added 1 commit

• 57e1ee17 - Enable 50 MeV gTowers in simulation

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @will ,@thompson as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 57e1ee17)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1140]

added 1043 commits

• 57e1ee17...933b1a89 - 1041 commits from branch atlas:main
• 8c504d59 - Merge branch 'main' into gFEX_SimUpd
• 72ae9d43 - Fix large-R jet eta for HLT seeding

Compare with previous version

This merge request affects 3 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @thompson ,@akraszna ,@will ,@tamartin as watchers

added EDM analysis-review-required labels

CI Result FAILURE (hash 72ae9d43)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1156]

Still a few test failures. Setting review-user-action-required while you have a look. Looks like a lot of "eta out of range" failures.

The compiler warning is

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/gFEXSysSim.cxx: In member function 'virtual StatusCode LVL1::gFEXSysSim::execute(LVL1::gFEXOutputCollection*)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/gFEXSysSim.cxx:323:14: warning: unused variable 'tob_status' [-Wunused-variable]
  323 |          int tob_status = (tob >> statusBit) & statusMask;
      |              ^~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/gFEXSysSim.cxx:333:14: warning: unused variable 'tob_status' [-Wunused-variable]
  333 |          int tob_status = (tob >> statusBit) & statusMask;
      |              ^~~~~~~~~~

Tom - L1 shifter

added review-user-action-required label

removed review-pending-level-1 label

added 1 commit

• 21c3bdb7 - Fix eta out of range

Compare with previous version

This merge request affects 3 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @akraszna ,@tamartin ,@thompson ,@will as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 21c3bdb7)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1902]

added 2 commits

• 4e8adcc0 - Remove comments
• c7caeb3c - Update reference file

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @thompson ,@okumura ,@vmartin ,@tamartin ,@akraszna ,@martindl ,@will as watchers

added changes-trigger-counts label

WARNING: big files (>100K) are found in the changeset

440K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

CI Result SUCCESS (hash c7caeb3c)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1907]

added analysis-review-approved label and removed analysis-review-required label

Looks good from my perspective.

Cheers, Anne (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 0e4877c7

mentioned in merge request !68639 (merged)