Adapt muon AlignmentErrorTool for NSW hits

The AlignmentErrorTool contains some logic to convert athena identifiers into alignable chamber string IDs as used in the muon alignment, and in particular in the alignment error CLOB read from the CondDB and used to configure the AlignmentErrorTool.

This MR updates this logic for the run 3 and for the MM and sTGC identifiers:

• In the AlignmentErrorTool code itself, the handling of the hit IDs into alignable chamber string IDs is updated, along with some overall cleanup of the code
• And additional flag "has_nsw_hits" is added to the alignment error CLOB, to activate the error computation for NSW hits. This is done for backward compatibility: when flag is not present, the NSW hits are not considered, as was the case in the past.
• Support for the flag "has_nsw_hits" is added in MuonAlignmentErrorDbAlg and MuonAlignmentErrorData. Some overall cleanup of these classes is also performed.
• An AlignmentErrorTestAlg is added, along with its CA configuration, that dumps the result of the AlignmentErrorTool for the debugging.

I would say that probably @jojungge @stavrop and @kluit may want to check this MR.

Addresses ATLASRECTS-7818

marked this merge request as ready

Jenkins please retry a build

added 1 commit

• 52d37f65 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

resolved all threads

resolved all threads

added 1 commit

• 55ddef9a - Apply 4 suggestion(s) to 2 file(s)

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool

This merge request affects 2 files:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.cxx
• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.h

Adding @jojungge ,@pscholer ,@kluit ,@stavrop ,@rosati ,@apsallid as watchers

added MuonSpectrometer main review-pending-level-1 labels

added 1 commit

• 914fb3d4 - Fix name traslation -> translation

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool

This merge request affects 2 files:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.cxx
• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.h

Adding @apsallid ,@rosati ,@stavrop ,@kluit ,@pscholer ,@jojungge as watchers

This merge request affects 1 package:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool

This merge request affects 2 files:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.cxx
• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.h

Adding @apsallid ,@rosati ,@jojungge ,@stavrop ,@kluit ,@pscholer as watchers

added Run2-DataReco-output-changed Run2-MCOverlay-output-changed Run3-DataReco-output-changed Run3-MCOverlay-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 1d8996a8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1036]

This merge request affects 1 package:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool

This merge request affects 2 files:

• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.cxx
• MuonSpectrometer/MuonAlignment/MuonAlignError/MuonAlignErrorTool/src/AlignmentErrorTool.h

Adding @rosati ,@jojungge ,@kluit ,@apsallid ,@stavrop ,@pscholer as watchers