PROCTools: Ci reference script, Handle the case where a key message is truncated.

@wlampl just found a case where the script wasn't working because the output was truncated in a way I've not seen before.

changed title from Handle the case where a key message is truncated. to PROCTools: Ci reference script, Handle the case where a key message is truncated.

This merge request affects 1 package:

• Tools/PROCTools

This merge request affects 1 file:

• Tools/PROCTools/scripts/update_ci_reference_files.py

added Tools main review-pending-level-1 labels

CI Result SUCCESS (hash 7c60c392)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1051]

Hi @emoyse, I have a very minor query, which you are welcome to ignore. I'll set review-user-action-required for now but please set review-pending-level-1 once you've addressed the comment either way and I'll approve. Tom - L1 shifter

removed review-pending-level-1 label

added review-user-action-required label

added 3 commits

• 1b7eafe0 - Update to handle mkdir and cp consistently
• f9026922 - Put script in correct directory, and install it
• 1ffce8e0 - Simplification pointed out in the review

Compare with previous version

resolved all threads

added 1 commit

• 3216b5a6 - Remove duplicates from commands

Compare with previous version

@wlampl I pushed some changes which I think will resolve the issues you mentioned last night, specifically:

• it should be installed now
• the cp command have a slash added
• mkdir is anyway now part of the commands listed
• duplicates are removed

Obviously I can't easily test this, but locally it looks okay.

P.S. The reason why there wasn't a warning about both OverlayRun2MC and OverlayRun2MC_Legacy modifying the same file is you only get this warning in normal mode. This probably isn't great, so I'll have a rethink (and we definitely should print a warning about looking out for file-sizes)

This merge request affects 1 package:

• Tools/PROCTools

This merge request affects 3 files:

• Tools/PROCTools/CMakeLists.txt
• Tools/PROCTools/python/update_ci_reference_files.py
• Tools/PROCTools/scripts/update_ci_reference_files.py

added review-pending-level-1 label and removed review-user-action-required label

This merge request affects 1 package:

• Tools/PROCTools

This merge request affects 3 files:

• Tools/PROCTools/CMakeLists.txt
• Tools/PROCTools/python/update_ci_reference_files.py
• Tools/PROCTools/scripts/update_ci_reference_files.py

CI Result SUCCESS (hash 1ffce8e0)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1107]

added 1 commit

• 715bbad0 - Fix warnings found in MR

Compare with previous version

CI Result SUCCESS (hash 3216b5a6)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1110]

My apologies for spamming the CI - I should have killed this last pipeline. But to be clear, the pipeline with my fixes (715bbad0) is still running.

This merge request affects 1 package:

• Tools/PROCTools

This merge request affects 3 files:

• Tools/PROCTools/CMakeLists.txt
• Tools/PROCTools/python/update_ci_reference_files.py
• Tools/PROCTools/scripts/update_ci_reference_files.py