Skip to content
Snippets Groups Projects

DerivationBPHY: Add warnings for excess candidates

Merged Adam Edward Barton requested to merge abarton/athena:RefitWarning into main
All threads resolved!

Sometimes combinatoric explosions crash the shared writer. Adding warnings for easier debugging.

cc @wwalko @kfung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Adam Edward Barton marked this merge request as ready

    marked this merge request as ready

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
    • PhysicsAnalysis/JpsiUpsilonTools

    Affected files list will not be printed in this case

    Adding @wwalko ,@emmat ,@abarton ,@calpigia ,@jcatmore as watchers

  • :white_check_mark: CI Result SUCCESS (hash a27ff546)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1180]

  • Setting review-user-action-required until threads resolved. Tom - L1 shifter

  • added 1 commit

    • b0b86982 - Add CandidateLimit to prevent explosive combinatorics

    Compare with previous version

  • This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
    • PhysicsAnalysis/JpsiUpsilonTools

    Affected files list will not be printed in this case

    Adding @abarton ,@wwalko ,@emmat ,@calpigia ,@jcatmore as watchers

  • :white_check_mark: CI Result SUCCESS (hash b0b86982)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1229]

  • There are no issues with the CI but there are unresolved thread. Switching tags until these are resolved.

    -- James for L1

  • Kin Yip Fung resolved all threads

    resolved all threads

  • Changes are simple and passes CI. Approving for L1.

  • added review-approved label and removed review-pending-level-1 label

  • Tadej Novak mentioned in commit 28234626

    mentioned in commit 28234626

  • merged

  • Please register or sign in to reply
    Loading